Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
cmd/vet: Update canonical method check for new xml.Marshaler/Unmarshaler interfaces #6540
Before filing a bug, please check whether it has been fixed since the latest release. Search the issue tracker and check that you're running the latest version of Go: Run "go version" and compare against http://golang.org/doc/devel/release.html If a newer version of Go exists, install it and retry what you did to reproduce the problem. Thanks. What steps will reproduce the problem? If possible, include a link to a program on play.golang.org. 1. Download http://play.golang.org/p/5AGYi95HzX 2. Run go vet on it 3. What is the expected output? foo.go:14: method UnmarshalXML(wrong int) should have signature UnmarshalXML(*xml.Decoder, xml.StartElement) error What do you see instead? foo.go:10: method MarshalXML(e *xml.Encoder, start xml.StartElement) error should have signature MarshalXML() (byte, error) Which compiler are you using (5g, 6g, 8g, gccgo)? Which operating system are you using? Which version are you using? (run 'go version') Please provide any additional information below. The MarshalXML signature it checks is that of the interface that was removed before Go 1.0, UnmarshalXML isn't checked at all.