Skip to content

x/build: adding LUCI builders blocking submit is too manual #65439

@bcmills

Description

@bcmills

Go version

N/A

Output of go env in your module/workspace:

N/A

What did you do?

Review contributed changes that need additional testing (such as running on a longtest builder or a particular architecture) before they can be safely merged.

What did you see happen?

There is a “CHOOSE TRYJOBS” button, but IIRC it doesn't affect auto-submit, and it definitely doesn't stick when a new patchset is uploaded.

It is possible to leave a comment requesting that the author add a Cq-Include-Trybots: line to the commit message, but for small externally-contributed changes that can add an extra round-trip.

What did you expect to see?

Some way that I (as a reviewer) can mark the CL as ok to auto-submit provided that a specific set of additional LUCI builders succeeds.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Buildersx/build issues (builders, bots, dashboards)NeedsInvestigationSomeone must examine and confirm this is a valid issue and not a duplicate of an existing one.

    Type

    No type

    Projects

    Status

    Planned

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions