Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: TestScript failures #65452

Closed
gopherbot opened this issue Feb 2, 2024 · 4 comments
Closed

cmd/go: TestScript failures #65452

gopherbot opened this issue Feb 2, 2024 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "cmd/go" && test == "TestScript"

Issue created automatically to collect these failures.

Example (log):

vcs-test.golang.org rerouted to http://127.0.0.1:38655
https://vcs-test.golang.org rerouted to https://127.0.0.1:36249
go test proxy running at GOPROXY=http://127.0.0.1:33443/mod
2024/02/02 16:03:19 http: TLS handshake error from 127.0.0.1:34554: read tcp 127.0.0.1:36249->127.0.0.1:34554: read: connection reset by peer
2024/02/02 16:03:19 http: TLS handshake error from 127.0.0.1:34548: EOF
2024/02/02 16:03:19 http: TLS handshake error from 127.0.0.1:34528: EOF
--- FAIL: TestScript (1.11s)
    --- FAIL: TestScript/mod_get_fallback (66.99s)
        script_test.go:132: 2024-02-02T16:03:51Z
        script_test.go:134: $WORK=/workdir/tmp/cmd-go-test-687207055/tmpdir1040938466/mod_get_fallback3961943255
...
            # get https://proxy.golang.org/golang.org/x/mod/@v/list: 200 OK (0.010s)
            # get https://proxy.golang.org/golang.org/x/mod/@v/v0.14.0.info
            # get https://proxy.golang.org/golang.org/x/mod/@v/v0.14.0.info: 200 OK (0.003s)
            go: added golang.org/x/mod v0.14.0
            go: added golang.org/x/tools v0.17.0
            > stderr '# get https://proxy.golang.org/golang.org/x/tools/@v/list'
            matched: # get https://proxy.golang.org/golang.org/x/tools/@v/list
            > ! stderr '# get https://golang.org'
            matched: # get https://golang.org/x?go-get=1
        script_test.go:156: FAIL: testdata/script/mod_get_fallback.txt:11: stderr '# get https://golang.org': unexpected success

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 2, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "cmd/go" && test == "TestScript"
2024-02-02 15:13 linux-amd64-longtest-race go@244ccf47 cmd/go.TestScript (log)
vcs-test.golang.org rerouted to http://127.0.0.1:38655
https://vcs-test.golang.org rerouted to https://127.0.0.1:36249
go test proxy running at GOPROXY=http://127.0.0.1:33443/mod
2024/02/02 16:03:19 http: TLS handshake error from 127.0.0.1:34554: read tcp 127.0.0.1:36249->127.0.0.1:34554: read: connection reset by peer
2024/02/02 16:03:19 http: TLS handshake error from 127.0.0.1:34548: EOF
2024/02/02 16:03:19 http: TLS handshake error from 127.0.0.1:34528: EOF
--- FAIL: TestScript (1.11s)
    --- FAIL: TestScript/mod_get_fallback (66.99s)
        script_test.go:132: 2024-02-02T16:03:51Z
        script_test.go:134: $WORK=/workdir/tmp/cmd-go-test-687207055/tmpdir1040938466/mod_get_fallback3961943255
...
            # get https://proxy.golang.org/golang.org/x/mod/@v/list: 200 OK (0.010s)
            # get https://proxy.golang.org/golang.org/x/mod/@v/v0.14.0.info
            # get https://proxy.golang.org/golang.org/x/mod/@v/v0.14.0.info: 200 OK (0.003s)
            go: added golang.org/x/mod v0.14.0
            go: added golang.org/x/tools v0.17.0
            > stderr '# get https://proxy.golang.org/golang.org/x/tools/@v/list'
            matched: # get https://proxy.golang.org/golang.org/x/tools/@v/list
            > ! stderr '# get https://golang.org'
            matched: # get https://golang.org/x?go-get=1
        script_test.go:156: FAIL: testdata/script/mod_get_fallback.txt:11: stderr '# get https://golang.org': unexpected success

watchflakes

@bcmills
Copy link
Contributor

bcmills commented Feb 5, 2024

@cherrymui, this looks like it's just a duplicate of #65459 reported for the parent test. Is this second issue due to a bug in the watchflakes matching logic?

@cherrymui
Copy link
Member

LUCI watchflakes has a better understanding of subtests, whereas the old watchflakes doesn't. So the old one will report to parent whereas the LUCI one will report to the subtest. I'm not planning to improve the old one as it probably won't last very long. For now maybe you can change it to matching the text TestScript/mod_get_fallback.

@cherrymui
Copy link
Member

I modified the pattern on the other issue. Closing this as a dup.

@cherrymui cherrymui closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants