Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: don't let the tests leave core files behind #65476

Closed
mknyszek opened this issue Feb 2, 2024 · 3 comments
Closed

runtime: don't let the tests leave core files behind #65476

mknyszek opened this issue Feb 2, 2024 · 3 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.22

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Feb 2, 2024

https://go.dev/cl/525175 fixes a build issue that can cause flakiness of TestDependencies, but it hasn't been backported. This has showed up in the advisory builds for release.
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 2, 2024
@mknyszek
Copy link
Contributor Author

mknyszek commented Feb 2, 2024

@gopherbot Please open backport issues. This is a test-only fix that improves the stability of our release advisory builds.

@mknyszek mknyszek added this to the Go1.22 milestone Feb 2, 2024
@gopherbot gopherbot mentioned this issue Feb 2, 2024
Closed
@gopherbot
Copy link
Contributor

Backport issue(s) opened: #65477 (for 1.20), #65478 (for 1.21).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

@gopherbot gopherbot mentioned this issue Feb 2, 2024
Closed
@mknyszek mknyszek closed this as completed Feb 2, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/560896 mentions this issue: [release-branch.go1.21] runtime: don't let the tests leave core files behind

@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Feb 2, 2024
gopherbot pushed a commit that referenced this issue Feb 27, 2024
@ianlancetaylor @cagedmantis
[release-branch.go1.21] runtime: don't let the tests leave core files…
6d31b27 
… behind

Also add a check that we didn't leave any core files behind.

For #65476.
Fixes #65478. 

Change-Id: I30444ef43ad1a8cc1cacd3b75280f2128e104939
Reviewed-on: https://go-review.googlesource.com/c/go/+/525175
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit cffdfe8)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560896
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.22
Development

No branches or pull requests
3 participants
@mknyszek @dmitshur @gopherbot