Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: don't let the tests leave core files behind [1.21 backport] #65478

Closed
gopherbot opened this issue Feb 2, 2024 · 3 comments
Closed

runtime: don't let the tests leave core files behind [1.21 backport] #65478

gopherbot opened this issue Feb 2, 2024 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21.8

Comments

@gopherbot
Copy link
Contributor

@mknyszek requested issue #65476 to be considered for backport to the next 1.21 minor release.

@gopherbot Please open backport issues. This is a test-only fix that improves the stability of our release advisory builds.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 2, 2024
@gopherbot gopherbot mentioned this issue Feb 2, 2024
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 2, 2024
@gopherbot gopherbot added this to the Go1.21.7 milestone Feb 2, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/560896 mentions this issue: [release-branch.go1.21] runtime: don't let the tests leave core files behind

@mknyszek
Copy link
Contributor

mknyszek commented Feb 2, 2024

Note: this does not need to be backported to Go 1.22. That branch already has the fix, because it landed during the Go 1.22 dev cycle.

@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Feb 2, 2024
@gopherbot gopherbot modified the milestones: Go1.21.7, Go1.21.8 Feb 6, 2024
@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Feb 7, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 7, 2024
gopherbot pushed a commit that referenced this issue Feb 27, 2024
@ianlancetaylor @cagedmantis
[release-branch.go1.21] runtime: don't let the tests leave core files…
6d31b27 
… behind

Also add a check that we didn't leave any core files behind.

For #65476.
Fixes #65478. 

Change-Id: I30444ef43ad1a8cc1cacd3b75280f2128e104939
Reviewed-on: https://go-review.googlesource.com/c/go/+/525175
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Keith Randall <khr@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit cffdfe8)
Reviewed-on: https://go-review.googlesource.com/c/go/+/560896
@gopherbot
Copy link
Contributor Author

Closed by merging 6d31b27 to release-branch.go1.21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.21.8
Development

No branches or pull requests
4 participants
@mknyszek @dmitshur @dr2chase @gopherbot