Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: remove the "allowModfileModifications" setting #65546

Open
findleyr opened this issue Feb 6, 2024 · 0 comments
Open

x/tools/gopls: remove the "allowModfileModifications" setting #65546

findleyr opened this issue Feb 6, 2024 · 0 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Feb 6, 2024

Following up on #56570, we should remove the deprecated allowModFileModifications setting.

Quoting: #56570 (comment):

Generally speaking, this setting means "whatever the go command does to your go.mod file is OK". That's not a coherent mode of operation for gopls to support, which is why it has no test coverage. Additionally, the documentation says "this option will eventually be removed".

We should surface the deprecation notice in gopls@v0.15.0, and remove in gopls@v0.16.0.

I don't think this setting works well, so I don't see how it could be useful to any users. However, if you need this setting, please explain why!

@findleyr findleyr added this to the gopls/v0.16.0 milestone Feb 6, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants