Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: Conn.WaitConnectionState unrealiable? #657

Closed
gopherbot opened this issue Mar 8, 2010 · 3 comments
Closed

crypto/tls: Conn.WaitConnectionState unrealiable? #657

gopherbot opened this issue Mar 8, 2010 · 3 comments

Comments

@gopherbot
Copy link

@gopherbot gopherbot commented Mar 8, 2010

by matthew.dempsky:

There's no documentation on what crypto.tls.Conn.WaitConnectionState is 
actually supposed to do, so maybe this is intentional, but looking at the code, 
it appears that if the handshake has already been made by time the caller 
calls WaitConnectionState, then he will get an immediate ConnectionState 
response, and then the channel will still get queued.

I would think the channel should only get added to waitQueue if the 
handshake has not already been made, so that the record processor does not 
try to write to the channel again later.

http://golang.org/src/pkg/crypto/tls/record_process.go#L134
@gopherbot

This comment has been minimized.

Copy link
Author

@gopherbot gopherbot commented Mar 10, 2010

Comment 1 by stephenm@golang.org:

Owner changed to a...@golang.org.

@agl

This comment has been minimized.

Copy link
Contributor

@agl agl commented Mar 24, 2010

Comment 2:

Hi Matt :)
Sorry for the delay. I'll see if I can take a look at this today. In short: the TLS 
package is rather incomplete. Mostly I need a week to flesh it out. You're welcome to 
email me directly if you intend to use it in anger.
Cheers

Status changed to Accepted.

@rsc

This comment has been minimized.

Copy link
Contributor

@rsc rsc commented Apr 8, 2010

Comment 3:

Status changed to Duplicate.

Merged into issue #715.

@mikioh mikioh changed the title crypto.tls.Conn.WaitConnectionState unrealiable? crypto/tls: Conn.WaitConnectionState unrealiable? Jan 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.