Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: Go 1.22.0 fails to build from source on armv7 Alpine Linux [1.22 backport] #65760

Closed
gopherbot opened this issue Feb 16, 2024 · 2 comments
Closed

runtime: Go 1.22.0 fails to build from source on armv7 Alpine Linux [1.22 backport] #65760

gopherbot opened this issue Feb 16, 2024 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.22.1

Comments

@gopherbot
Copy link
Contributor

@cherrymui requested issue #65601 to be considered for backport to the next 1.22 minor release.

@gopherbot please backport this to Go 1.22 release. This is a regression, causing runtime crashes with GOARM=7.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 16, 2024
@gopherbot gopherbot mentioned this issue Feb 16, 2024
Closed
@gopherbot gopherbot added this to the Go1.22.1 milestone Feb 16, 2024
@cherrymui cherrymui changed the title cmd/go: Go 1.22.0 fails to build from source on armv7 Alpine Linux [1.22 backport] runtime: Go 1.22.0 fails to build from source on armv7 Alpine Linux [1.22 backport] Feb 16, 2024
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 16, 2024
@prattmic prattmic added the CherryPickApproved Used during the release process for point releases label Feb 21, 2024
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 21, 2024
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/567555 mentions this issue: [release-branch.go1.22] runtime/internal/atomic: correct GOARM=7 guard at a DMB instruction

gopherbot pushed a commit that referenced this issue Feb 27, 2024
@cherrymui @cagedmantis
[release-branch.go1.22] runtime/internal/atomic: correct GOARM=7 guar…
8fe2ad6 
…d at a DMB instruction

CL 525637 changed to the guard of DMB instruction from the
compiled-in runtime.goarm value to GOARM_7 macro and CPU feature
detection. It missed a place where runtime.goarm is loaded to a
register and reused later. This CL corrects the condition.

Updates #65601.
Fixes #65760.

Change-Id: I2ddefd03a1eb1048dbec0254c6e234c65b054279
Reviewed-on: https://go-review.googlesource.com/c/go/+/564855
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit a0226c5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/567555
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Bypass: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging 8fe2ad6 to release-branch.go1.22.

bradfitz pushed a commit to tailscale/go that referenced this issue Mar 5, 2024
@cherrymui @bradfitz
[release-branch.go1.22] runtime/internal/atomic: correct GOARM=7 guar…
7ca66f3 
…d at a DMB instruction

CL 525637 changed to the guard of DMB instruction from the
compiled-in runtime.goarm value to GOARM_7 macro and CPU feature
detection. It missed a place where runtime.goarm is loaded to a
register and reused later. This CL corrects the condition.

Updates golang#65601.
Fixes golang#65760.

Change-Id: I2ddefd03a1eb1048dbec0254c6e234c65b054279
Reviewed-on: https://go-review.googlesource.com/c/go/+/564855
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit a0226c5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/567555
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Bypass: Carlos Amedee <carlos@golang.org>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Mar 6, 2024
@cherrymui @romaindoumenc
[release-branch.go1.22] runtime/internal/atomic: correct GOARM=7 guar…
307f186 
…d at a DMB instruction

CL 525637 changed to the guard of DMB instruction from the
compiled-in runtime.goarm value to GOARM_7 macro and CPU feature
detection. It missed a place where runtime.goarm is loaded to a
register and reused later. This CL corrects the condition.

Updates golang#65601.
Fixes golang#65760.

Change-Id: I2ddefd03a1eb1048dbec0254c6e234c65b054279
Reviewed-on: https://go-review.googlesource.com/c/go/+/564855
Run-TryBot: Cherry Mui <cherryyz@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
(cherry picked from commit a0226c5)
Reviewed-on: https://go-review.googlesource.com/c/go/+/567555
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
TryBot-Bypass: Carlos Amedee <carlos@golang.org>
@golang golang locked and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.22.1
Development

No branches or pull requests
2 participants
@prattmic @gopherbot