Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/coordinator/remote: improve how work directories are set on gomote instances #65826

Open
cagedmantis opened this issue Feb 20, 2024 · 2 comments
Open

x/build/internal/coordinator/remote: improve how work directories are set on gomote instances #65826

cagedmantis opened this issue Feb 20, 2024 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@cagedmantis
Copy link
Contributor

Currently, when you SSH into a gomote, the proxy inserts a command to change into the working directory. Historically, this has caused different platforms to have different experiences when the SSH user starts their session. There should be a way of improving this experience. One possible solution is by modifying the SSH server in the buildlet to initiate the user's session in the work directory.
@cagedmantis cagedmantis added Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 20, 2024
@cagedmantis cagedmantis added this to the Backlog milestone Feb 20, 2024
@dmitshur
Copy link
Contributor

Moving to Unreleased, since Backlog seems to be for issues tied to the Go release cycle that aren't assigned a specific release milestone yet. (https://go.dev/wiki/HandlingIssues#milestones)

@dmitshur dmitshur modified the milestones: Backlog, Unreleased Feb 20, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/592497 mentions this issue: all: set the working directory for Windows SSH gomote sessions

gopherbot pushed a commit to golang/build that referenced this issue Jun 14, 2024
@cagedmantis @gopherbot
all: set the working directory for Windows SSH gomote sessions
a486a30 
This change configures the working directory used when a Windows
gomote SSH session is created. When a user starts an SSH session they
will no longer need to change into the windows working directory. In
order to enable this, the conpty package version has been updated to a
version that supports this option.

Updates golang/go#65826

Change-Id: I89654adb229d81c2d07b8632ae18459696ff62c5
Reviewed-on: https://go-review.googlesource.com/c/build/+/592497
Reviewed-by: Michael Pratt <mpratt@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Carlos Amedee <carlos@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@cagedmantis @dmitshur @gopherbot