cmd/go: go build executes unnecessary mkdir

[davecheney]

What steps will reproduce the problem?

% go build -x
WORK=/tmp/go-build249279931
mkdir -p $WORK/crypto/hmac/_obj/
mkdir -p $WORK/crypto/
cd /home/dfc/go/src/pkg/crypto/hmac
/home/dfc/go/pkg/tool/linux_arm/5g -o $WORK/crypto/hmac/_obj/_go_.5 -p crypto/hmac
-complete -D _/home/dfc/go/src/pkg/crypto/hmac -I $WORK ./hmac.go
/home/dfc/go/pkg/tool/linux_arm/pack grcP $WORK $WORK/crypto/hmac.a
$WORK/crypto/hmac/_obj/_go_.5

What is the expected output? What do you see instead?

mkdir -p $WORK/crypto/hmac/_obj/

will create $WORK/crypto/

so

mkdir -p $WORK/crypto/

is unnecessary.

Please use labels and text to provide additional information.

[robpike]

Comment 1:

Seems to happen for any nested package such as crypto/hmac or encoding/binary. Curious:
if you go one level deeper, say encoding/binary/foo, it mkdirs only two, not three
mkdir -p $WORK/encoding/binary/foo/_obj/
mkdir -p $WORK/encoding/binary/
A quick scan of the source doesn't make the reason obvious. It's also very unimportant.

Labels changed: added priority-later, removed priority-triage.

Status changed to Accepted.

[gopherbot]

Comment 2 by frederic.husson@baleinoid.fr:

In build.go you have a makedir for  the objdir and one for the target and you have in
modeBuild if not a.link : a.target = a.objpkg
    // Make build directory.
    obj := a.objdir
    if err := b.mkdir(obj); err != nil {
        return err
    }
    // make target directory
    dir, _ := filepath.Split(a.target)
    if dir != "" {
        if err := b.mkdir(dir); err != nil {
            return err
        }
    }

[rsc]

Comment 3:

Labels changed: added go1.3maybe.

[rsc]

Comment 4:

Labels changed: added release-none, removed go1.3maybe.

[rsc]

Comment 5:

Labels changed: added repo-main.

[rsc]

This doesn't matter; fixing it would make the code more fragile.