You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While testing zero-config gopls (#57979), I noticed that jumping to definition on a vendored Kubernetes module creates a new View for that module. This could result in increased memory usage, and partial references results.
We should not create Views for vendored modules. The fix seems very straightforward, so we should fix this for v0.15.0.
The text was updated successfully, but these errors were encountered:
gopherbot
added
Tools
This label describes issues relating to any tools in the x/tools repository.
gopls
Issues related to the Go language server, gopls.
labels
Feb 20, 2024
…for vendored modules
We should not create Views for vendored modules, just as we don't create
Views for modules in the module cache. With this change, gopls behaves
similarly to gopls@v0.14.2 when navigating around the Kubernetes repo.
Also add some test coverage that vendored packages are not workspace
packages.
Fixesgolang/go#65830
Change-Id: If9883dc9616774952bd49c395e1c0d37ad3c2a6a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/565458
Reviewed-by: Alan Donovan <adonovan@google.com>
Auto-Submit: Robert Findley <rfindley@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
(cherry picked from commit a821e61)
Reviewed-on: https://go-review.googlesource.com/c/tools/+/565695
While testing zero-config gopls (#57979), I noticed that jumping to definition on a vendored Kubernetes module creates a new View for that module. This could result in increased memory usage, and partial references results.
We should not create Views for vendored modules. The fix seems very straightforward, so we should fix this for v0.15.0.
The text was updated successfully, but these errors were encountered: