Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/misc: TestRenamePackage_IntermediateTestVariant failures #65853

Closed
gopherbot opened this issue Feb 21, 2024 · 2 comments
Closed

x/tools/gopls/internal/test/integration/misc: TestRenamePackage_IntermediateTestVariant failures #65853

gopherbot opened this issue Feb 21, 2024 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRenamePackage_IntermediateTestVariant"

Issue created automatically to collect these failures.

Example (log):

serve.go:441: debug server listening at http://localhost:49242
serve.go:441: debug server listening at http://localhost:49243
#### Start Gopls Test Logs for "TestRenamePackage_IntermediateTestVariant/default"
[Trace - 23:19:06.184 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fake.Editor","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/buildlet/tmp/gopls-test-2949072519/TestRenamePackage_IntermediateTestVariant/default/gopath","GOPROXY":"file:///tmp/buildlet/tmp/gopls-test-2949072519/TestRenamePackage_IntermediateTestVariant/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/buildlet/tmp/gopls-test-2949072519/TestRenamePackage_IntermediateTestVariant/default/work","name":"work"}]}


[Trace - 23:19:06.187 PM] Received response 'initialize - (1)' in 2ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.apply_fix","gopls.change_signature","gopls.check_upgrades","gopls.diagnose_files","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.views","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.22.0\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"(unknown)\"}"}}

...
panic: test timed out after 10m0s
running tests:
	TestRenamePackage_IntermediateTestVariant (5m24s)
	TestRenamePackage_IntermediateTestVariant/default (5m24s)

testing.(*T).Run(0xc000e67d40, {0xf30dd0f?, 0xf32b7be?}, 0xc0030dd090)
	/tmp/buildlet/go/src/testing/testing.go:1750 +0x3ab
golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run(0xc000335040, 0xc000e67d40, {0xf39e330, 0x2f2}, 0xf811ec8, {0x0, 0x0, 0xe8fc32f?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:167 +0x485
golang.org/x/tools/gopls/internal/test/integration.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/regtest.go:56
golang.org/x/tools/gopls/internal/test/integration/misc.TestRenamePackage_IntermediateTestVariant(0xc000e67d40?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/misc/rename_test.go:766 +0x3d
testing.tRunner(0xc000e67d40, 0xf811a10)

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. labels Feb 21, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRenamePackage_IntermediateTestVariant"
2024-02-20 20:33 darwin-amd64-12_0 tools@3f67f80b go@6cbe522f x/tools/gopls/internal/test/integration/misc.TestRenamePackage_IntermediateTestVariant (log) 
serve.go:441: debug server listening at http://localhost:49242
serve.go:441: debug server listening at http://localhost:49243
#### Start Gopls Test Logs for "TestRenamePackage_IntermediateTestVariant/default"
[Trace - 23:19:06.184 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fake.Editor","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"0s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/tmp/buildlet/tmp/gopls-test-2949072519/TestRenamePackage_IntermediateTestVariant/default/gopath","GOPROXY":"file:///tmp/buildlet/tmp/gopls-test-2949072519/TestRenamePackage_IntermediateTestVariant/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///tmp/buildlet/tmp/gopls-test-2949072519/TestRenamePackage_IntermediateTestVariant/default/work","name":"work"}]}


[Trace - 23:19:06.187 PM] Received response 'initialize - (1)' in 2ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.add_telemetry_counters","gopls.apply_fix","gopls.change_signature","gopls.check_upgrades","gopls.diagnose_files","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.maybe_prompt_for_telemetry","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_go_work_command","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.start_profile","gopls.stop_profile","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.views","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator","label"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"go1.22.0\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"(unknown)\"}"}}

...
panic: test timed out after 10m0s
running tests:
	TestRenamePackage_IntermediateTestVariant (5m24s)
	TestRenamePackage_IntermediateTestVariant/default (5m24s)

testing.(*T).Run(0xc000e67d40, {0xf30dd0f?, 0xf32b7be?}, 0xc0030dd090)
	/tmp/buildlet/go/src/testing/testing.go:1750 +0x3ab
golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run(0xc000335040, 0xc000e67d40, {0xf39e330, 0x2f2}, 0xf811ec8, {0x0, 0x0, 0xe8fc32f?})
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/runner.go:167 +0x485
golang.org/x/tools/gopls/internal/test/integration.Run(...)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/regtest.go:56
golang.org/x/tools/gopls/internal/test/integration/misc.TestRenamePackage_IntermediateTestVariant(0xc000e67d40?)
	/tmp/buildlet/gopath/src/golang.org/x/tools/gopls/internal/test/integration/misc/rename_test.go:766 +0x3d
testing.tRunner(0xc000e67d40, 0xf811a10)

— watchflakes

@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Feb 21, 2024
@gopherbot gopherbot added this to the Unreleased milestone Feb 21, 2024
@findleyr
Copy link
Contributor

Yet another hanging Go command on Darwin...

goroutine 44779 [syscall, 5 minutes]:
syscall.syscall(0xc0009d6200?, 0xe8ed629?, 0xe8e8a13?, 0xc0009d6278?)
	/tmp/buildlet/go/src/runtime/sys_darwin.go:23 +0x70
syscall.readlen(0xff47890?, 0xfee4c60?, 0x14?)
	/tmp/buildlet/go/src/syscall/syscall_darwin.go:239 +0x34
syscall.forkExec({0xc00d1e7470?, 0x5e?}, {0xc0019cb000, 0x2, 0x2}, 0xc00d1e7470?)
	/tmp/buildlet/go/src/syscall/exec_unix.go:220 +0x451
syscall.StartProcess(...)
	/tmp/buildlet/go/src/syscall/exec_unix.go:254
os.startProcess({0xc00d1e7470, 0x17}, {0xc0019cb000, 0x2, 0x2}, 0xc0009d6518)
	/tmp/buildlet/go/src/os/exec_posix.go:54 +0x312
os.StartProcess({0xc00d1e7470, 0x17}, {0xc0019cb000, 0x2, 0x2}, 0xc0009d6518)
	/tmp/buildlet/go/src/os/exec.go:111 +0x54
os/exec.(*Cmd).Start(0xc0023f7ce0)
	/tmp/buildlet/go/src/os/exec/exec.go:700 +0x5f1
golang.org/x/tools/internal/gocommand.runCmdContext({0xf821098, 0xc00a8ab350}, 0xc0023f7ce0)

Closing as a dupe of #65853.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Feb 22, 2024
@gabyhelp gabyhelp mentioned this issue Aug 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr