You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the following code, gopls produces multiple diagnostics at X:
varX=YvarY=ZvarZ=X
This is due to the way gopls unpacks the initialization cycle errors returned by go/types.
Minor, but filing this for tracking purposes. If/when we improve structured errors in go/types, we should fix this. We could also add some ad-hoc suppression of the duplicates.
The text was updated successfully, but these errors were encountered:
gopherbot
added
Tools
This label describes issues relating to any tools in the x/tools repository.
gopls
Issues related to the Go language server, gopls.
labels
Feb 22, 2024
CL 565838 changed the way initialization cycle errors were reporting,
and would have broken gopls' parsing of continuation errors, yet no
x/tools tests failed.
Add a test for this behavior. Due to golang/go#65877, duplicate
diagnostics had to be suppressed for this test.
Updates golang/go#65877
Change-Id: I48244ac469ab78d2e40bf92ec061671cef72c6d9
Reviewed-on: https://go-review.googlesource.com/c/tools/+/566075
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adonovan@google.com>
In the following code, gopls produces multiple diagnostics at X:
This is due to the way gopls unpacks the initialization cycle errors returned by go/types.
Minor, but filing this for tracking purposes. If/when we improve structured errors in go/types, we should fix this. We could also add some ad-hoc suppression of the duplicates.
The text was updated successfully, but these errors were encountered: