-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: inconsistency major version between pseudo version and base version #66053
Comments
Is this an issue for pkgsite or cmd/gp more generally? I think this is working as intended, where a commit can have multiple identities, and while go generally relies on human convention to enforce semver/major version suffix matches for manual tags, all commits will have a an identity they can be imported as. For a while, it was a well-known workaround to import prometheus this way (before it adopted the /v2 suffix). cc @bcmills |
I think this is a pkgsite(proxy) issue since bad version will be generate go.mod and zip (https://proxy.golang.org/github.com/ricoberger/script_exporter/@v/v1.3.1-0.20240210123610-ebeaf9415eb1.mod), which can be download by non-go tools like curl, etc. |
Note that And
Also note that there is nothing preventing the owner of the module from adding a tag like |
Also note that https://pkg.go.dev/github.com/ricoberger/script_exporter@v1.3.1-0.20240210123610-ebeaf9415eb1 displays a |
What is the URL of the page with the issue?
https://pkg.go.dev/github.com/ricoberger/script_exporter@v1.3.1-0.20240210123610-ebeaf9415eb1
What did you do?
https://github.com/ricoberger/script_exporter has released an valid version "v2.18.0" (commit id: ebeaf9415eb1) (just an example no offence)
However script_exporter's mod has no major suffix with "/v2", but github.com/ricoberger/script_exporter@v1.3.1-0.20240210123610-ebeaf9415eb1 is an valid "pseudo version" according to "mod spec"
My concern is clearly v2 incompatible with v1, but import "v1.3.1-0.20240210123610-ebeaf9415eb1" that will breaks minimal version selection since both version (
v1.3.0
andv1.3.1-0.20240210123610-ebeaf9415eb1
) has same major version.What did you see happen?
https://pkg.go.dev/github.com/ricoberger/script_exporter@v1.3.1-0.20240210123610-ebeaf9415eb1 is valid version
What did you expect to see?
No valid version if pseudo version related commit is after different major semver tag.
The text was updated successfully, but these errors were encountered: