Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/mail: us-ascii encoded headers are not decoded #6611

Closed
eaigner opened this issue Oct 17, 2013 · 8 comments
Closed

net/mail: us-ascii encoded headers are not decoded #6611

eaigner opened this issue Oct 17, 2013 · 8 comments
Assignees
Milestone

Comments

@eaigner
Copy link
Contributor

@eaigner eaigner commented Oct 17, 2013

Currently net/mail only decodes q-encoded headers if they are either iso-8859-1 or utf-8
encoded. us-ascii is also a valid value, and should be handled too.

It should be trivial to add "us-ascii" to the "iso-8859-1" switch
case in 

http://golang.org/src/pkg/net/mail/message.go#L464

and here

http://golang.org/src/pkg/net/mail/message.go#L444
@rsc
Copy link
Contributor

@rsc rsc commented Oct 18, 2013

Comment 1:

For after Go 1.2
https://golang.org/cl/14990045

Labels changed: added priority-later, go1.3, removed priority-triage.

Owner changed to @rsc.

Status changed to Started.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 2:

Labels changed: added release-go1.3, removed go1.3.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 3:

Labels changed: added repo-main.

@rsc
Copy link
Contributor

@rsc rsc commented May 9, 2014

Comment 4:

No one seems to care about this so kicking it down the road.

Labels changed: added release-go1.4, removed release-go1.3.

@gopherbot
Copy link

@gopherbot gopherbot commented Sep 10, 2014

Comment 5:

CL https://golang.org/cl/101330049 mentions this issue.
@gopherbot
Copy link

@gopherbot gopherbot commented Sep 16, 2014

Comment 6:

CL https://golang.org/cl/14990045 mentions this issue.
@rsc
Copy link
Contributor

@rsc rsc commented Sep 16, 2014

Comment 7:

This issue was closed by revision 06e4b06.

Status changed to Fixed.

@gopherbot
Copy link

@gopherbot gopherbot commented Oct 15, 2014

Comment 8:

CL https://golang.org/cl/132680044 mentions this issue.
@eaigner eaigner added fixed labels Oct 15, 2014
@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman added a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
Fixes golang#6611.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/14990045
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
Fixes golang#6611.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/14990045
wheatman added a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
Fixes golang#6611.

LGTM=bradfitz
R=bradfitz
CC=golang-codereviews
https://golang.org/cl/14990045
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.