Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: "nil metadata for %q" panic in Snapshot.getPackageHandles (reported by telemetry) #66144

Closed
adonovan opened this issue Mar 6, 2024 · 2 comments
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@adonovan
Copy link
Member

adonovan commented Mar 6, 2024

This stack j8z9tw was reported by telemetry:

getPackageHandles.func1:+6 is:

			if mp == nil {
				panic(fmt.Sprintf("nil metadata for %q", id))
			}
crash/crash
runtime.gopanic:+69
golang.org/x/tools/gopls/internal/cache.(*Snapshot).getPackageHandles.func1:+6
golang.org/x/tools/gopls/internal/cache.(*Snapshot).getPackageHandles.func1:+23
golang.org/x/tools/gopls/internal/cache.(*Snapshot).getPackageHandles:+48
golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackage:+8
golang.org/x/tools/gopls/internal/cache.(*Snapshot).PackageDiagnostics:+28
golang.org/x/tools/gopls/internal/cache.(*Snapshot).orphanedFileDiagnostics:+31
golang.org/x/tools/gopls/internal/cache.(*Session).OrphanedFileDiagnostics:+50
golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedViews:+54
golang.org/x/tools/gopls/internal/server.(*server).didModifyFiles.func2:+1
runtime.goexit:+0
golang.org/x/tools/gopls@v0.15.1 devel linux/amd64 coc.nvim (4)

Issue created by golang.org/x/tools/gopls/internal/telemetry/cmd/stacks.

@adonovan adonovan added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository. gopls/telemetry-wins labels Mar 6, 2024
@gopherbot gopherbot added this to the Unreleased milestone Mar 6, 2024
@adonovan adonovan modified the milestones: Unreleased, gopls/v0.16.0 Mar 7, 2024
@findleyr findleyr modified the milestones: gopls/v0.16.0, gopls/v0.17.0 May 23, 2024
@findleyr
Copy link
Member

We're not going to be able to fix this until we have crash reporting again (broken in v0.16.2). Maybe we'll get signal from the v0.17.0 prerelease, but I'll plan this for v0.18.0.

@adonovan
Copy link
Member Author

We haven't seen a peep out of this one for months. Perhaps it was fixed by accident, or took on a new guise. Either way, closing.

@adonovan adonovan closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls/telemetry-wins gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants