Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net: IPv6 parser should fail with 8 groups plus one blank #6628

Closed
gopherbot opened this issue Oct 20, 2013 · 13 comments

Comments

Projects
None yet
4 participants
@gopherbot
Copy link

commented Oct 20, 2013

by raul.san@sent.com:

At parsing an IPv6 address with 8 groups plus a blank group, it is removing that blank
group instead of return nil since it is not valid.

Related to: https://groups.google.com/forum/#!topic/golang-nuts/aEo-UrOmHu8
@minux

This comment has been minimized.

Copy link
Member

commented Oct 20, 2013

Comment 1:

sorry, i don't understand this issue.
this is the example that is referenced in the golang-nuts post:
http://play.golang.org/p/bC1nblkq_u
could you elaborate what should be expected output?
if that program is not related, could you please give an example and
its expected output?

Status changed to WaitingForReply.

@gopherbot

This comment has been minimized.

Copy link
Author

commented Oct 20, 2013

Comment 2 by raul.san@sent.com:

The ouput at parsing a address like "a1:a2:a3:a4::b1:b2:b3:b4" should be nil because 
no more than 6 groups in addition to the "::" may be present.
See definiition of IPv6v4-comp in http://tools.ietf.org/html/rfc5321#section-4.1.3
@gopherbot

This comment has been minimized.

Copy link
Author

commented Oct 20, 2013

Comment 3 by raul.san@sent.com:

I mean the definition of IPv6-comp
@minux

This comment has been minimized.

Copy link
Member

commented Oct 20, 2013

Comment 4:

thank you for the details.

Labels changed: added priority-later, go1.3, removed priority-triage.

Status changed to Accepted.

@gopherbot

This comment has been minimized.

Copy link
Author

commented Oct 20, 2013

Comment 5 by raul.san@sent.com:

The title should be "net:IPv6 parser should fail with 7 groups plus one blank"
@gopherbot

This comment has been minimized.

Copy link
Author

commented Oct 20, 2013

Comment 6 by raul.san@sent.com:

Note, that is also should be nil with 7 groups plus one blank:
http://play.golang.org/p/nuieTkQCdN
@minux

This comment has been minimized.

Copy link
Member

commented Oct 20, 2013

Comment 7:

according to http://tools.ietf.org/html/rfc4291#section-2.2,
"The use of "::" indicates one or more groups of 16 bits of zeros."
so 7 groups plus one :: is in fact acceptable.
@gopherbot

This comment has been minimized.

Copy link
Author

commented Oct 23, 2013

Comment 8 by alex@lx.lc:

Submitted https://golang.org/cl/15990043 which I believe will fix this.
@rsc

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2013

Comment 9:

Labels changed: added release-go1.3.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2013

Comment 10:

Labels changed: removed go1.3.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Dec 4, 2013

Comment 11:

Labels changed: added repo-main.

@minux

This comment has been minimized.

Copy link
Member

commented Dec 5, 2013

Comment 12:

https://golang.org/cl/15990043/

Status changed to Started.

@mikioh

This comment has been minimized.

Copy link
Contributor

commented Dec 20, 2013

Comment 13:

This issue was closed by revision 487dff1.

Status changed to Fixed.

@rsc rsc added this to the Go1.3 milestone Apr 14, 2015

@rsc rsc removed the release-go1.3 label Apr 14, 2015

@golang golang locked and limited conversation to collaborators Jun 25, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.