proposal: x/net/internal/socks: make it public

[noonien]

Proposal Details

x/net/proxy.SOCKS5 returns an x/net/internal/socks.Dialer, when Dialing to create a new connection, a *socks.Conn is returned, and the BoundAddr() method can be accessed by creating an interface, however, because the socks.Addr struct is not available, its fields cannot be accessed without using reflection, or parsing strings.

I'm unsure what the benefit of making the socks package internal is, but if making it non-internal is an issue, perhaps there is another way of exposing BoundAddr().

[mateuszlitwin]

+1

Current function func SOCKS5(network, address string, auth *Auth, forward Dialer) (Dialer, error) is not flexible enough. In particular, this function does not support dialing socks5 servers implementing alternative authentication methods. On the other hand x/net/internal/socks.Dialer.Authenticate allow users to implement custom authentication protocols. I would rather have direct access to the x/net/internal/socks package than use x/net/proxy.