-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/pkgsite: right aligned ¶ #66458
Comments
I never understood why the link is a pilcrow, but keeping it close to the symbol name always seemed logical to me. If your screen is wide, the right-hand side is not where your eyes or mouse are likely to be. |
@adonovan can I take a crack at it even though it doesn't have a help wanted label just yet? This ruleset seems to be the issue. .Documentation-function h4,
.Documentation-type h4,
.Documentation-typeFunc h4,
.Documentation-typeMethod h4 {
align-items: baseline;
display: flex;
justify-content: space-between;
} While this is useful for the "since version" display, it causes this alignment issue with other h4s. Empirically speaking, all h4s under func/type sections seem to have the class h4.Documentation-functionHeader,
h4.Documentation-typeHeader,
h4.Documentation-typeFuncHeader,
h4.Documentation-typeMethodHeader {
align-items: baseline;
display: flex;
justify-content: space-between;
} |
Please do! You should send your CL to @jba for review. Thanks. |
Change https://go.dev/cl/574719 mentions this issue: |
What is the URL of the page with the issue?
https://pkg.go.dev/google.golang.org/grpc#hdr-Experimental
What is your user agent?
Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/122.0.0.0 Safari/537.36
Screenshot
What did you do?
Hovered over the Experimental section.
What did you see happen?
Saw the ¶ link for the heading on the right hand side.
What did you expect to see?
To see the ¶ link right after the heading text. The link does appear after the heading text for overview, constants, variables section however functions and types sections show right aligned ¶.
The text was updated successfully, but these errors were encountered: