Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http, x/net/http2: data race in multiple tests #66519

Open
cherrymui opened this issue Mar 25, 2024 · 17 comments
Open

net/http, x/net/http2: data race in multiple tests #66519

cherrymui opened this issue Mar 25, 2024 · 17 comments
Assignees
@neild
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.25

Comments

@cherrymui
Copy link
Member

cherrymui commented Mar 25, 2024 •
edited
Loading 

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)

Combinding multiple watchflakes issues, e.g. #66499, #66489, #66484, #66479, #66476.
This was referenced Mar 25, 2024
Closed
Closed
Closed
Closed
Closed
@cherrymui cherrymui changed the title net/http: data race in multiple tests net/http, x/net/http2: data race in multiple tests Mar 25, 2024
@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- (pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)
2024-03-20 17:26 linux-amd64-longtest-race net@c7877ac4 go@364687bd x/net/http2.TestTransportUsesGoAwayDebugError_Body (log) 
==================
WARNING: DATA RACE
Write at 0x00c0004fea20 by goroutine 30525:
  golang.org/x/net/http2.(*testClientConnNetConn).Close()
      /workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:733 +0x32
  golang.org/x/net/http2.(*ClientConn).closeConn()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1086 +0x109
  golang.org/x/net/http2.(*clientConnReadLoop).cleanup.deferwrap1()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:2357 +0x33
  runtime.deferreturn()
...
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1311 +0x7e4
  golang.org/x/net/http2.(*ClientConn).RoundTrip()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1293 +0x104
  golang.org/x/net/http2.(*testClientConn).roundTrip.func2()
      /workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:420 +0xcd
  golang.org/x/net/http2.(*testSyncHooks).goRun.func1()
      /workdir/gopath/src/golang.org/x/net/http2/testsync.go:126 +0x81
==================
--- FAIL: TestTransportUsesGoAwayDebugError_Body (0.00s)
    testing.go:1398: race detected during execution of test
2024-03-21 09:28 linux-amd64-race net@ebc8168a go@83a6c13e x/net/http2.TestTransportUsesGoAwayDebugError_RoundTrip (log) 
==================
WARNING: DATA RACE
Write at 0x00c000540080 by goroutine 21587:
  golang.org/x/net/http2.(*testClientConnNetConn).Close()
      /workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:733 +0x32
  golang.org/x/net/http2.(*ClientConn).closeConn()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1086 +0x109
  golang.org/x/net/http2.(*clientConnReadLoop).cleanup.deferwrap1()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:2357 +0x33
  runtime.deferreturn()
...
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1311 +0x7e4
  golang.org/x/net/http2.(*ClientConn).RoundTrip()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1293 +0x104
  golang.org/x/net/http2.(*testClientConn).roundTrip.func2()
      /workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:420 +0xcd
  golang.org/x/net/http2.(*testSyncHooks).goRun.func1()
      /workdir/gopath/src/golang.org/x/net/http2/testsync.go:126 +0x81
==================
--- FAIL: TestTransportUsesGoAwayDebugError_RoundTrip (0.00s)
    testing.go:1398: race detected during execution of test
2024-03-21 17:25 linux-arm64-race go@5e1e3a00 net/http.TestReadResponseCloseInMiddle (log) 
==================
WARNING: DATA RACE
Read at 0x00c0000db703 by goroutine 12887:
  testing.(*common).logDepth()
      /tmp/workdir/go/src/testing/testing.go:1023 +0x390
  testing.(*common).log()
      /tmp/workdir/go/src/testing/testing.go:1010 +0x80
  testing.(*common).Logf()
      /tmp/workdir/go/src/testing/testing.go:1061 +0x58
  net/http_test.testServerNoWriteTimeout.func1()
...
      /tmp/workdir/go/src/testing/testing.go:2159 +0x6e0
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:2027 +0xb74
  net/http_test.TestMain()
      /tmp/workdir/go/src/net/http/main_test.go:24 +0x5c
  main.main()
      _testmain.go:1225 +0x294
==================
--- FAIL: TestReadResponseCloseInMiddle (1.01s)
    testing.go:1398: race detected during execution of test
2024-03-21 17:25 linux-arm64-race go@5e1e3a00 net/http.TestClientWithCorrectTLSServerName (log) 
--- FAIL: TestClientWithCorrectTLSServerName (0.00s)
    --- FAIL: TestClientWithCorrectTLSServerName/h2 (0.05s)
        testing.go:1398: race detected during execution of test
    --- FAIL: TestClientWithCorrectTLSServerName/https1 (0.07s)
        testing.go:1398: race detected during execution of test
2024-03-21 17:25 linux-arm64-race go@5e1e3a00 net/http.TestServerNoReadTimeout (log) 
--- FAIL: TestServerNoReadTimeout (0.00s)
    --- FAIL: TestServerNoReadTimeout/h2 (0.11s)
        serve_test.go:818: Server.Config.ReadTimeout = 0
        serve_test.go:818: Server.Config.ReadTimeout = -1
        testing.go:1398: race detected during execution of test
2024-03-21 20:00 linux-arm64-race go@aa1b50e1 net/http.TestServeFileMimeType (log) 
==================
WARNING: DATA RACE
Read at 0x00c0001d0863 by goroutine 14616:
  testing.(*common).logDepth()
      /tmp/workdir/go/src/testing/testing.go:1023 +0x390
  testing.(*common).log()
      /tmp/workdir/go/src/testing/testing.go:1010 +0x80
  testing.(*common).Logf()
      /tmp/workdir/go/src/testing/testing.go:1061 +0x58
  net/http_test.testServerNoWriteTimeout.func1()
...
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:2027 +0xb74
  net/http_test.TestMain()
      /tmp/workdir/go/src/net/http/main_test.go:24 +0x5c
  main.main()
      _testmain.go:1225 +0x294
==================
--- FAIL: TestServeFileMimeType (0.00s)
    --- FAIL: TestServeFileMimeType/h2 (0.04s)
        testing.go:1398: race detected during execution of test
2024-03-21 20:00 linux-arm64-race go@aa1b50e1 net/http.TestClientWithCorrectTLSServerName (log) 
--- FAIL: TestClientWithCorrectTLSServerName (0.00s)
    --- FAIL: TestClientWithCorrectTLSServerName/h2 (0.03s)
        testing.go:1398: race detected during execution of test
    --- FAIL: TestClientWithCorrectTLSServerName/https1 (0.03s)
        testing.go:1398: race detected during execution of test
2024-03-21 20:00 linux-arm64-race go@aa1b50e1 net/http.TestResponseBodyReadAfterClose (log) 
--- FAIL: TestResponseBodyReadAfterClose (0.00s)
    --- FAIL: TestResponseBodyReadAfterClose/h2 (0.06s)
        testing.go:1398: race detected during execution of test
2024-03-21 20:26 freebsd-amd64-race go@5d29578f net/http.TestClientTimeoutCancel (log) 
==================
WARNING: DATA RACE
Read at 0x00c00019d703 by goroutine 13899:
  testing.(*common).logDepth()
      /tmp/workdir/go/src/testing/testing.go:1025 +0x504
  testing.(*common).log()
      /tmp/workdir/go/src/testing/testing.go:1012 +0xa4
  testing.(*common).Logf()
      /tmp/workdir/go/src/testing/testing.go:1063 +0x6a
  net/http_test.testServerNoWriteTimeout.func1()
...
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:2072 +0xf17
  net/http_test.TestMain()
      /tmp/workdir/go/src/net/http/main_test.go:24 +0x64
  main.main()
      _testmain.go:1225 +0x2d4
==================
--- FAIL: TestClientTimeoutCancel (0.00s)
    --- FAIL: TestClientTimeoutCancel/h2 (0.03s)
        testing.go:1413: race detected during execution of test
2024-03-21 20:26 freebsd-amd64-race go@5d29578f net/http.TestTLSHandshakeTimeout (log) 
--- FAIL: TestTLSHandshakeTimeout (0.00s)
    --- FAIL: TestTLSHandshakeTimeout/h2 (0.25s)
        testing.go:1413: race detected during execution of test
    --- FAIL: TestTLSHandshakeTimeout/https1 (0.25s)
        testing.go:1413: race detected during execution of test
2024-03-21 20:26 freebsd-amd64-race go@5d29578f net/http.TestDeleteRedirects (log) 
--- FAIL: TestDeleteRedirects (0.00s)
    --- FAIL: TestDeleteRedirects/h1 (0.01s)
        testing.go:1413: race detected during execution of test
    --- FAIL: TestDeleteRedirects/h2 (0.03s)
        testing.go:1413: race detected during execution of test
2024-03-21 20:26 linux-s390x-ibm-race go@5d29578f net/http.TestTLSServer (log) 
==================
WARNING: DATA RACE
Read at 0x00c00031ad43 by goroutine 11157:
  testing.(*common).logDepth()
      /data/golang/workdir/go/src/testing/testing.go:1025 +0x5ad
  testing.(*common).log()
      /data/golang/workdir/go/src/testing/testing.go:1012 +0xb5
  testing.(*common).Logf()
      /data/golang/workdir/go/src/testing/testing.go:1063 +0x62
  net/http_test.testServerNoWriteTimeout.func1()
...
  net/http_test.TestMain()
      /data/golang/workdir/go/src/net/http/main_test.go:24 +0x87
  main.main()
      _testmain.go:1225 +0x35d
==================
--- FAIL: TestTLSServer (0.00s)
    --- FAIL: TestTLSServer/h2 (0.04s)
        testing.go:1413: race detected during execution of test
    --- FAIL: TestTLSServer/https1 (0.03s)
        testing.go:1413: race detected during execution of test
2024-03-21 20:26 linux-s390x-ibm-race go@5d29578f net/http.TestTLSServerClosesConnection (log) 
--- FAIL: TestTLSServerClosesConnection (0.00s)
    --- FAIL: TestTLSServerClosesConnection/https1 (1.83s)
        transport_test.go:3539: successes = 20 of 20
        testing.go:1413: race detected during execution of test
2024-03-21 20:26 linux-s390x-ibm-race go@5d29578f net/http.TestNewClientServerTest (log) 
--- FAIL: TestNewClientServerTest (0.00s)
    testing.go:1413: race detected during execution of test
2024-03-21 21:01 freebsd-amd64-race go@b4f37e18 net/http.TestServerNoReadTimeout (log) 
==================
WARNING: DATA RACE
Read at 0x00c0000ced43 by goroutine 13145:
  testing.(*common).logDepth()
      /tmp/workdir/go/src/testing/testing.go:1025 +0x504
  testing.(*common).log()
      /tmp/workdir/go/src/testing/testing.go:1012 +0xa4
  testing.(*common).Logf()
      /tmp/workdir/go/src/testing/testing.go:1063 +0x6a
  net/http_test.testServerNoWriteTimeout.func1()
...
  net/http_test.TestMain()
      /tmp/workdir/go/src/net/http/main_test.go:24 +0x64
  main.main()
      _testmain.go:1225 +0x2d4
==================
--- FAIL: TestServerNoReadTimeout (0.00s)
    --- FAIL: TestServerNoReadTimeout/h2 (0.18s)
        serve_test.go:818: Server.Config.ReadTimeout = 0
        serve_test.go:818: Server.Config.ReadTimeout = -1
        testing.go:1413: race detected during execution of test
2024-03-21 21:01 freebsd-amd64-race go@b4f37e18 net/http.TestFileServerNotDirError (log) 
--- FAIL: TestFileServerNotDirError (0.00s)
    --- FAIL: TestFileServerNotDirError/h2 (0.06s)
        --- FAIL: TestFileServerNotDirError/h2/FS (0.03s)
            testing.go:1413: race detected during execution of test
2024-03-21 21:01 freebsd-amd64-race go@b4f37e18 net/http.TestServeContentErrorMessages (log) 
--- FAIL: TestServeContentErrorMessages (0.00s)
    --- FAIL: TestServeContentErrorMessages/h2 (0.06s)
        testing.go:1413: race detected during execution of test
2024-03-21 22:14 linux-s390x-ibm-race go@4f0408a3 net/http.TestTransportProxyGetConnectHeader (log) 
==================
WARNING: DATA RACE
Read at 0x00c00055ea03 by goroutine 7825:
  testing.(*common).logDepth()
      /data/golang/workdir/go/src/testing/testing.go:1025 +0x5ad
  testing.(*common).log()
      /data/golang/workdir/go/src/testing/testing.go:1012 +0xb5
  testing.(*common).Logf()
      /data/golang/workdir/go/src/testing/testing.go:1063 +0x62
  net/http_test.testServerNoWriteTimeout.func1()
...
      /data/golang/workdir/go/src/testing/testing.go:2204 +0xa27
  testing.(*M).Run()
      /data/golang/workdir/go/src/testing/testing.go:2072 +0x1087
  net/http_test.TestMain()
      /data/golang/workdir/go/src/net/http/main_test.go:24 +0x87
  main.main()
      _testmain.go:1225 +0x35d
==================
--- FAIL: TestTransportProxyGetConnectHeader (0.00s)
    testing.go:1413: race detected during execution of test
2024-03-21 22:14 linux-s390x-ibm-race go@4f0408a3 net/http.TestTransportMaxPerHostIdleConns (log) 
--- FAIL: TestTransportMaxPerHostIdleConns (0.00s)
    testing.go:1413: race detected during execution of test
2024-03-21 22:14 linux-s390x-ibm-race go@4f0408a3 net/http.TestTransportConnectionCloseOnRequest (log) 
--- FAIL: TestTransportConnectionCloseOnRequest (0.00s)
    testing.go:1413: race detected during execution of test
2024-03-22 04:41 freebsd-amd64-race go@ac0b2f95 net/http.TestServerReadTimeout (log) 
==================
WARNING: DATA RACE
Read at 0x00c000411a43 by goroutine 16509:
  testing.(*common).logDepth()
      /tmp/workdir/go/src/testing/testing.go:1025 +0x504
  testing.(*common).log()
      /tmp/workdir/go/src/testing/testing.go:1012 +0xa4
  testing.(*common).Logf()
      /tmp/workdir/go/src/testing/testing.go:1063 +0x6a
  net/http_test.testServerNoWriteTimeout.func1()
...
--- FAIL: TestServerReadTimeout (0.00s)
    --- FAIL: TestServerReadTimeout/h2 (0.15s)
        serve_test.go:767: Server.Config.ReadTimeout = 5ms
        clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:20256: write tcp 127.0.0.1:20254->127.0.0.1:20256: i/o timeout
        serve_test.go:781: Get error, retrying: Post "https://127.0.0.1:20254": EOF
        serve_test.go:767: Server.Config.ReadTimeout = 10ms
        clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:20271: write tcp 127.0.0.1:20270->127.0.0.1:20271: i/o timeout
        serve_test.go:781: Get error, retrying: Post "https://127.0.0.1:20270": EOF
        serve_test.go:767: Server.Config.ReadTimeout = 20ms
        clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:20289: write tcp 127.0.0.1:20288->127.0.0.1:20289: i/o timeout
        serve_test.go:781: Get error, retrying: Post "https://127.0.0.1:20288": EOF
        serve_test.go:767: Server.Config.ReadTimeout = 40ms
        testing.go:1413: race detected during execution of test
2024-03-22 04:41 linux-arm64-race go@ac0b2f95 net/http.TestTimeoutHandlerContextCanceled (log) 
==================
WARNING: DATA RACE
Read at 0x00c0004b6a03 by goroutine 14002:
  testing.(*common).logDepth()
      /tmp/workdir/go/src/testing/testing.go:1025 +0x390
  testing.(*common).log()
      /tmp/workdir/go/src/testing/testing.go:1012 +0x80
  testing.(*common).Logf()
      /tmp/workdir/go/src/testing/testing.go:1063 +0x58
  net/http_test.testServerNoWriteTimeout.func1()
...
  testing.(*M).Run()
      /tmp/workdir/go/src/testing/testing.go:2072 +0xb74
  net/http_test.TestMain()
      /tmp/workdir/go/src/net/http/main_test.go:24 +0x5c
  main.main()
      _testmain.go:1225 +0x294
==================
--- FAIL: TestTimeoutHandlerContextCanceled (0.00s)
    --- FAIL: TestTimeoutHandlerContextCanceled/h2 (0.03s)
        testing.go:1413: race detected during execution of test
2024-03-22 04:41 linux-arm64-race go@ac0b2f95 net/http.TestClientWrites (log) 
--- FAIL: TestClientWrites (0.00s)
    --- FAIL: TestClientWrites/h1 (0.01s)
        testing.go:1413: race detected during execution of test
2024-03-22 04:41 linux-arm64-race go@ac0b2f95 net/http.TestClientHead (log) 
--- FAIL: TestClientHead (0.00s)
    --- FAIL: TestClientHead/h2 (0.04s)
        testing.go:1413: race detected during execution of test
2024-03-22 13:07 linux-amd64-race go@27f41bb1 net/http.TestServerWriteTimeout (log) 
==================
WARNING: DATA RACE
Read at 0x00c0003f3a43 by goroutine 9723:
  testing.(*common).logDepth()
      /workdir/go/src/testing/testing.go:1023 +0x504
  testing.(*common).log()
      /workdir/go/src/testing/testing.go:1010 +0xa4
  testing.(*common).Logf()
      /workdir/go/src/testing/testing.go:1061 +0x6a
  net/http_test.testServerNoWriteTimeout.func1()
...
--- FAIL: TestServerWriteTimeout (0.01s)
    --- FAIL: TestServerWriteTimeout/h2 (0.28s)
        serve_test.go:850: Server.Config.WriteTimeout = 5ms
        clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:55944: write tcp 127.0.0.1:46125->127.0.0.1:55944: i/o timeout
        serve_test.go:881: Get error, retrying: Get "https://127.0.0.1:46125": EOF
        serve_test.go:850: Server.Config.WriteTimeout = 10ms
        clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:45006: read tcp 127.0.0.1:41155->127.0.0.1:45006: i/o timeout
        serve_test.go:881: Get error, retrying: Get "https://127.0.0.1:41155": read tcp 127.0.0.1:45006->127.0.0.1:41155: read: connection reset by peer
        serve_test.go:850: Server.Config.WriteTimeout = 20ms
        clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:57380: write tcp 127.0.0.1:45699->127.0.0.1:57380: i/o timeout
        serve_test.go:881: Get error, retrying: Get "https://127.0.0.1:45699": EOF
        serve_test.go:850: Server.Config.WriteTimeout = 40ms
        clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:48784: write tcp 127.0.0.1:44769->127.0.0.1:48784: i/o timeout
        serve_test.go:881: Get error, retrying: Get "https://127.0.0.1:44769": EOF
        serve_test.go:850: Server.Config.WriteTimeout = 80ms
        testing.go:1398: race detected during execution of test
2024-03-22 13:07 linux-amd64-race go@27f41bb1 net/http.TestFileServerDirWithRootFile (log) 
--- FAIL: TestFileServerDirWithRootFile (0.00s)
    --- FAIL: TestFileServerDirWithRootFile/h1 (0.02s)
        --- FAIL: TestFileServerDirWithRootFile/h1/FileServerFS (0.02s)
            testing.go:1398: race detected during execution of test
2024-03-22 13:07 linux-amd64-race go@27f41bb1 net/http.TestResponseControllerSetFutureReadDeadline (log) 
--- FAIL: TestResponseControllerSetFutureReadDeadline (0.00s)
    --- FAIL: TestResponseControllerSetFutureReadDeadline/h2 (0.13s)
        testing.go:1398: race detected during execution of test
2024-03-22 16:12 darwin-amd64-race go@c9c88d73 net/http.TestWriteDeadlineExtendedOnNewRequest (log) 
==================
WARNING: DATA RACE
Read at 0x00c0001bcee3 by goroutine 5758:
  testing.(*common).logDepth()
      /tmp/buildlet/go/src/testing/testing.go:1023 +0x504
  testing.(*common).log()
      /tmp/buildlet/go/src/testing/testing.go:1010 +0xa4
  testing.(*common).Logf()
      /tmp/buildlet/go/src/testing/testing.go:1061 +0x6a
  net/http_test.testServerNoWriteTimeout.func1()
...
      /tmp/buildlet/go/src/testing/testing.go:2159 +0x8be
  testing.(*M).Run()
      /tmp/buildlet/go/src/testing/testing.go:2027 +0xf17
  net/http_test.TestMain()
      /tmp/buildlet/go/src/net/http/main_test.go:24 +0x64
  main.main()
      _testmain.go:1225 +0x2d4
==================
--- FAIL: TestWriteDeadlineExtendedOnNewRequest (0.00s)
    testing.go:1398: race detected during execution of test
2024-03-22 16:12 darwin-amd64-race go@c9c88d73 net/http.TestIdleConnH2Crash (log) 
--- FAIL: TestIdleConnH2Crash (0.00s)
    --- FAIL: TestIdleConnH2Crash/h2 (0.10s)
        testing.go:1398: race detected during execution of test
2024-03-22 16:12 darwin-amd64-race go@c9c88d73 net/http.TestServerNoReadTimeout (log) 
--- FAIL: TestServerNoReadTimeout (0.00s)
    testing.go:1398: race detected during execution of test
2024-03-22 16:14 linux-s390x-ibm-race go@c2b14631 net/http.TestServerTimeouts (log) 
==================
WARNING: DATA RACE
Read at 0x00c0004b9563 by goroutine 11183:
  testing.(*common).logDepth()
      /data/golang/workdir/go/src/testing/testing.go:1023 +0x5ad
  testing.(*common).log()
      /data/golang/workdir/go/src/testing/testing.go:1010 +0xb5
  testing.(*common).Logf()
      /data/golang/workdir/go/src/testing/testing.go:1061 +0x62
  net/http_test.testServerNoWriteTimeout.func1()
...
      /data/golang/workdir/go/src/testing/testing.go:2027 +0x1087
  net/http_test.TestMain()
      /data/golang/workdir/go/src/net/http/main_test.go:24 +0x87
  main.main()
      _testmain.go:1225 +0x35d
==================
--- FAIL: TestServerTimeouts (0.00s)
    --- FAIL: TestServerTimeouts/h1 (0.15s)
        serve_test.go:5982: retrying after error with duration 10ms: http Get #1: Get "http://127.0.0.1:43589": EOF
        testing.go:1398: race detected during execution of test
2024-03-22 16:14 linux-s390x-ibm-race go@c2b14631 net/http.TestResponseControllerSetPastReadDeadline (log) 
--- FAIL: TestResponseControllerSetPastReadDeadline (0.00s)
    --- FAIL: TestResponseControllerSetPastReadDeadline/h2 (0.06s)
        testing.go:1398: race detected during execution of test
2024-03-22 16:14 linux-s390x-ibm-race go@c2b14631 net/http.TestResponseControllerSetFutureReadDeadline (log) 
--- FAIL: TestResponseControllerSetFutureReadDeadline (0.00s)
    --- FAIL: TestResponseControllerSetFutureReadDeadline/h2 (0.04s)
        testing.go:1398: race detected during execution of test
2024-03-22 16:33 linux-amd64-race go@1c864333 net/http.TestIssue3644 (log) 
==================
WARNING: DATA RACE
Read at 0x00c000158d43 by goroutine 11489:
  testing.(*common).logDepth()
      /workdir/go/src/testing/testing.go:1023 +0x504
  testing.(*common).log()
      /workdir/go/src/testing/testing.go:1010 +0xa4
  testing.(*common).Logf()
      /workdir/go/src/testing/testing.go:1061 +0x6a
  net/http_test.testServerNoWriteTimeout.func1()
...
  testing.(*M).Run()
      /workdir/go/src/testing/testing.go:2027 +0xf17
  net/http_test.TestMain()
      /workdir/go/src/net/http/main_test.go:24 +0x64
  main.main()
      _testmain.go:1225 +0x2d4
==================
--- FAIL: TestIssue3644 (0.01s)
    --- FAIL: TestIssue3644/h2 (0.10s)
        testing.go:1398: race detected during execution of test
2024-03-22 16:33 linux-amd64-race go@1c864333 net/http.TestServerWriteHijackZeroBytes (log) 
--- FAIL: TestServerWriteHijackZeroBytes (0.00s)
    testing.go:1398: race detected during execution of test
2024-03-22 16:33 linux-amd64-race go@1c864333 net/http.TestServerExpect (log) 
--- FAIL: TestServerExpect (0.00s)
    testing.go:1398: race detected during execution of test

— watchflakes

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- (pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)
2024-03-21 11:49 gotip-linux-amd64-race go@68a508cd net/http.TestResponseControllerEnableFullDuplex/h2 (log) 
=== RUN   TestResponseControllerEnableFullDuplex/h2
=== PAUSE TestResponseControllerEnableFullDuplex/h2
=== CONT  TestResponseControllerEnableFullDuplex/h2
==================
WARNING: DATA RACE
Read at 0x00c0005d8ee3 by goroutine 12954:
  testing.(*common).logDepth()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1023 +0x504
  testing.(*common).log()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1010 +0xa4
...
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2159 +0x8be
  testing.(*M).Run()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2027 +0xf17
  net/http_test.TestMain()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/net/http/main_test.go:24 +0x64
  main.main()
      _testmain.go:1225 +0x2d4
==================
    testing.go:1398: race detected during execution of test
--- FAIL: TestResponseControllerEnableFullDuplex/h2 (0.12s)
2024-03-21 17:25 gotip-linux-amd64-longtest-race go@5e1e3a00 net/http.TestWriteDeadlineExtendedOnNewRequest/h1 (log) 
=== RUN   TestWriteDeadlineExtendedOnNewRequest/h1
==================
WARNING: DATA RACE
Read at 0x00c000434383 by goroutine 6899:
  testing.(*common).logDepth()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1023 +0x504
  testing.(*common).log()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1010 +0xa4
  testing.(*common).Logf()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1061 +0x6a
...
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2159 +0x8be
  testing.(*M).Run()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2027 +0xf17
  net/http_test.TestMain()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/net/http/main_test.go:24 +0x64
  main.main()
      _testmain.go:1225 +0x2d4
==================
    testing.go:1398: race detected during execution of test
--- FAIL: TestWriteDeadlineExtendedOnNewRequest/h1 (0.39s)
2024-03-21 17:25 gotip-linux-amd64-race go@5e1e3a00 net/http.TestServerReadTimeout/h2 (log) 
=== RUN   TestServerReadTimeout/h2
=== PAUSE TestServerReadTimeout/h2
=== CONT  TestServerReadTimeout/h2
    serve_test.go:767: Server.Config.ReadTimeout = 5ms
    clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:48958: write tcp 127.0.0.1:37087->127.0.0.1:48958: i/o timeout
    serve_test.go:781: Get error, retrying: Post "https://127.0.0.1:37087": EOF
    serve_test.go:767: Server.Config.ReadTimeout = 10ms
    clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:46140: write tcp 127.0.0.1:43953->127.0.0.1:46140: i/o timeout
    serve_test.go:781: Get error, retrying: Post "https://127.0.0.1:43953": EOF
    serve_test.go:767: Server.Config.ReadTimeout = 20ms
    clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:56944: write tcp 127.0.0.1:44497->127.0.0.1:56944: i/o timeout
    serve_test.go:781: Get error, retrying: Post "https://127.0.0.1:44497": EOF
    serve_test.go:767: Server.Config.ReadTimeout = 40ms
    clientserver_test.go:210: server log: http: TLS handshake error from 127.0.0.1:58788: read tcp 127.0.0.1:36415->127.0.0.1:58788: i/o timeout
    serve_test.go:781: Get error, retrying: Post "https://127.0.0.1:36415": write tcp 127.0.0.1:58788->127.0.0.1:36415: write: broken pipe
    serve_test.go:767: Server.Config.ReadTimeout = 80ms
    testing.go:1398: race detected during execution of test
--- FAIL: TestServerReadTimeout/h2 (0.44s)
2024-03-21 20:26 gotip-linux-amd64-race go@5d29578f net/http.TestTransportReuseConnection_Gzip_Chunked/h2 (log) 
=== RUN   TestTransportReuseConnection_Gzip_Chunked/h2
=== PAUSE TestTransportReuseConnection_Gzip_Chunked/h2
=== CONT  TestTransportReuseConnection_Gzip_Chunked/h2
    transport_test.go:4731: GetConn("127.0.0.1:42009")
    transport_test.go:4734: ConnectStart("tcp", "127.0.0.1:42009")
    transport_test.go:4735: ConnectDone("tcp", "127.0.0.1:42009", <nil>)
    transport_test.go:4732: GotConn({Conn:0xc001384008 Reused:false WasIdle:false IdleTime:0s})
    transport_test.go:4731: GetConn("127.0.0.1:42009")
    transport_test.go:4732: GotConn({Conn:0xc001384008 Reused:true WasIdle:true IdleTime:282.648µs})
    testing.go:1413: race detected during execution of test
--- FAIL: TestTransportReuseConnection_Gzip_Chunked/h2 (0.11s)
2024-03-21 21:01 gotip-linux-amd64-race go@b4f37e18 net/http.TestResponseControllerSetFutureWriteDeadline/h2 (log) 
=== RUN   TestResponseControllerSetFutureWriteDeadline/h2
=== PAUSE TestResponseControllerSetFutureWriteDeadline/h2
=== CONT  TestResponseControllerSetFutureWriteDeadline/h2
==================
WARNING: DATA RACE
Read at 0x00c0004c5be3 by goroutine 6168:
  testing.(*common).logDepth()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1025 +0x504
  testing.(*common).log()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1012 +0xa4
...
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2204 +0x8be
  testing.(*M).Run()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2072 +0xf17
  net/http_test.TestMain()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/net/http/main_test.go:24 +0x64
  main.main()
      _testmain.go:1225 +0x2d4
==================
    testing.go:1413: race detected during execution of test
--- FAIL: TestResponseControllerSetFutureWriteDeadline/h2 (0.11s)
2024-03-22 16:33 gotip-linux-amd64-longtest-race go@1c864333 net/http.TestServerNoWriteTimeout (log) 
=== RUN   TestServerNoWriteTimeout
    testing.go:1398: race detected during execution of test
--- FAIL: TestServerNoWriteTimeout (0.36s)
    serve_test.go:910: server write response: client disconnected
2024-03-22 16:33 gotip-linux-amd64-race go@1c864333 net/http.TestDeleteRedirects/h1 (log) 
=== RUN   TestDeleteRedirects/h1
=== PAUSE TestDeleteRedirects/h1
=== CONT  TestDeleteRedirects/h1
==================
WARNING: DATA RACE
Read at 0x00c0000dc863 by goroutine 7850:
  testing.(*common).logDepth()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1023 +0x504
  testing.(*common).log()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1010 +0xa4
...
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2159 +0x8be
  testing.(*M).Run()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:2027 +0xf17
  net/http_test.TestMain()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/net/http/main_test.go:24 +0x64
  main.main()
      _testmain.go:1225 +0x2d4
==================
    testing.go:1398: race detected during execution of test
--- FAIL: TestDeleteRedirects/h1 (0.04s)
2024-03-22 16:39 gotip-windows-amd64-race go@5f5b20c4 net/http.TestResponseControllerSetPastWriteDeadline/h2 (log) 
=== RUN   TestResponseControllerSetPastWriteDeadline/h2
=== PAUSE TestResponseControllerSetPastWriteDeadline/h2
=== CONT  TestResponseControllerSetPastWriteDeadline/h2
==================
WARNING: DATA RACE
Read at 0x00c00037bbe3 by goroutine 10724:
  testing.(*common).logDepth()
      C:/b/s/w/ir/x/w/goroot/src/testing/testing.go:1023 +0x504
  testing.(*common).log()
      C:/b/s/w/ir/x/w/goroot/src/testing/testing.go:1010 +0xa4
...
      C:/b/s/w/ir/x/w/goroot/src/testing/testing.go:2159 +0x8be
  testing.(*M).Run()
      C:/b/s/w/ir/x/w/goroot/src/testing/testing.go:2027 +0xf17
  net/http_test.TestMain()
      C:/b/s/w/ir/x/w/goroot/src/net/http/main_test.go:24 +0x64
  main.main()
      _testmain.go:1225 +0x2d4
==================
    testing.go:1398: race detected during execution of test
--- FAIL: TestResponseControllerSetPastWriteDeadline/h2 (0.09s)

— watchflakes

This was referenced Mar 25, 2024
Closed
Closed
Closed
Closed
@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-03-21 21:04 gotip-linux-amd64-longtest-race go@87056756 [build] (log) 
[I2024-03-21T21:15:35.262457Z 15550 0 sink.go:276] SinkServer: warm-up started
[I2024-03-21T21:15:35.262531Z 15550 0 sink.go:346] SinkServer: starting HTTP server...
[I2024-03-21T21:15:35.263574Z 15550 0 sink.go:281] SinkServer: warm-up ended
[I2024-03-21T21:15:35.263853Z 15550 0 cmd_stream.go:473] rdb-stream: starting the test command - ["/home/swarming/.swarming/w/ir/cache/tools/bin/result_adapter" "go" "-v=false" "--" "/home/swarming/.swarming/w/ir/x/w/goroot/bin/go" "tool" "dist" "test" "-json" "-race" "archive/zip" "compress/flate" "crypto/dsa" "crypto/internal/edwards25519" "crypto/internal/edwards25519/field" "crypto/internal/nistec" "crypto/rsa" "crypto/subtle" "crypto/tls" "database/sql" "encoding/gob" "encoding/xml" "go/build" "go/internal/gcimporter" "go/internal/srcimporter" "go/parser" "go/types" "hash/maphash" "image/gif" "image/jpeg" "index/suffixarray" "internal/abi" "internal/chacha8rand" "internal/cpu" "internal/godebugs" "internal/intern" "internal/poll" "internal/reflectlite" "internal/trace" "internal/trace/v2" "io" "log/syslog" "math" "math/big" "math/bits" "math/rand" "math/rand/v2" "net" "net/http" "net/http/httptrace" "net/http/pprof" "net/netip" "os" "os/signal" "reflect" "regexp" "runtime" "runtime/coverage" "runtime/internal/atomic" "runtime/pprof" "sort" "strconv" "strings" "sync" "sync/atomic" "syscall" "testing" "time" "cmd/api" "cmd/cgo/internal/test" "cmd/cgo/internal/testcarchive" "cmd/cgo/internal/testcshared" "cmd/cgo/internal/testerrors" "cmd/cgo/internal/testfortran" "cmd/cgo/internal/testplugin" "cmd/cgo/internal/testsanitizers" "cmd/cgo/internal/testshared" "compress/lzw" "container/list" "crypto/ecdsa" "crypto/elliptic" "crypto/internal/boring/bbig" "crypto/internal/randutil" "crypto/rand" "crypto/sha256" "crypto/sha512" "encoding/ascii85" "encoding/binary" "encoding/pem" "expvar" "go/internal/gccgoimporter" "hash" "hash/crc32" "hash/crc64" "internal/bytealg" "internal/cfg" "internal/coverage/cformat" "internal/coverage/stringtab" "internal/coverage/uleb128" "internal/lazyregexp" "internal/lazytemplate" "internal/nettrace" "internal/obscuretestdata" "internal/pkgbits" "internal/saferio" "internal/singleflight" "internal/syscall/unix" "internal/trace/v2/event/go122" "internal/trace/v2/testtrace" "log/slog/internal" "math/cmplx" "mime" "net/http/cgi" "net/http/fcgi" "net/http/httptest" "net/http/internal" "net/mail" "net/url" "plugin" "reflect/internal/example2" "runtime/internal/math" "runtime/internal/startlinetest" "slices" "testing/iotest" "testing/quick" "text/template" "time/tzdata" "unicode" "vendor/golang.org/x/crypto/chacha20" "vendor/golang.org/x/crypto/hkdf" "vendor/golang.org/x/net/http/httpguts" "vendor/golang.org/x/net/http/httpproxy" "vendor/golang.org/x/net/idna" "vendor/golang.org/x/net/nettest" "vendor/golang.org/x/text/secure/bidirule" "vendor/golang.org/x/text/transform" "vendor/golang.org/x/text/unicode/bidi" "vendor/golang.org/x/text/unicode/norm" "cmd/asm" "cmd/asm/internal/arch" "cmd/cgo/internal/cgotest" "cmd/cgo/internal/test/issue23555b" "cmd/cgo/internal/test/issue26213" "cmd/cgo/internal/test/issue27054" "cmd/cgo/internal/test/issue29563" "cmd/cgo/internal/test/issue52611a" "cmd/cgo/internal/test/issue8756" "cmd/cgo/internal/test/issue9400" "cmd/compile/internal/abt" "cmd/compile/internal/base" "cmd/compile/internal/bitvec" "cmd/compile/internal/coverage" "cmd/compile/internal/gc" "cmd/compile/internal/inline" "cmd/compile/internal/inline/inlheur" "cmd/compile/internal/ir" "cmd/compile/internal/mips" "cmd/compile/internal/objw" "cmd/compile/internal/reflectdata" "cmd/compile/internal/rttype" "cmd/compile/internal/walk" "cmd/covdata" "cmd/cover" "cmd/distpack" "cmd/go/internal/modinfo" "cmd/go/internal/mvs" "cmd/go/internal/search" "cmd/go/internal/test" "cmd/go/internal/vet" "cmd/go/internal/work" "cmd/internal/bio" "cmd/internal/dwarf" "cmd/internal/obj/loong64" "cmd/internal/objabi" "cmd/internal/objfile" "cmd/internal/osinfo" "cmd/internal/pkgpattern" "cmd/internal/test2json" "cmd/link/internal/loader" "cmd/link/internal/loong64" "cmd/link/internal/mips64" "cmd/link/internal/sym" "cmd/relnote" "cmd/trace" "cmd/vendor/github.com/google/pprof/internal/binutils" "cmd/vendor/github.com/google/pprof/internal/elfexec" "cmd/vendor/github.com/google/pprof/internal/plugin" "cmd/vendor/github.com/google/pprof/internal/report" "cmd/vendor/github.com/google/pprof/internal/symbolz" "cmd/vendor/golang.org/x/arch/arm/armasm" "cmd/vendor/golang.org/x/mod/modfile" "cmd/vendor/golang.org/x/sys/unix" "cmd/vendor/golang.org/x/telemetry/internal/configstore" "cmd/vendor/golang.org/x/telemetry/internal/upload" "cmd/vendor/golang.org/x/telemetry/upload" "cmd/vendor/golang.org/x/text/internal/language" "cmd/vendor/golang.org/x/text/internal/language/compact" "cmd/vendor/golang.org/x/text/internal/tag" "cmd/vendor/golang.org/x/tools/go/analysis" "cmd/vendor/golang.org/x/tools/go/analysis/passes/asmdecl" "cmd/vendor/golang.org/x/tools/go/analysis/passes/composite" "cmd/vendor/golang.org/x/tools/go/analysis/passes/ctrlflow" "cmd/vendor/golang.org/x/tools/go/analysis/passes/ifaceassert" "cmd/vendor/golang.org/x/tools/go/analysis/passes/internal/analysisutil" "cmd/vendor/golang.org/x/tools/go/analysis/passes/lostcancel" "cmd/vendor/golang.org/x/tools/go/analysis/passes/testinggoroutine" "cmd/vendor/golang.org/x/tools/go/analysis/passes/timeformat" "cmd/vendor/golang.org/x/tools/go/analysis/passes/unreachable" "cmd/vendor/golang.org/x/tools/go/types/objectpath" "cmd/vendor/golang.org/x/tools/internal/aliases" "cmd/vendor/golang.org/x/tools/internal/analysisinternal" "cmd/vendor/rsc.io/markdown"]
go tool dist: Failed: exit status 1
ok  	archive/zip	308.426s
ok  	compress/flate	379.937s
ok  	crypto/dsa	36.481s
ok  	crypto/internal/edwards25519	84.847s
ok  	crypto/internal/edwards25519/field	27.014s
...
Warning: no '=' in invocation-link-artifacts pair: "", ignoring
[I2024-03-21T21:29:21.958367Z 15550 0 cmd_stream.go:469] rdb-stream: the test process terminated
[I2024-03-21T21:29:21.958529Z 15550 0 sink.go:371] SinkServer: shutdown started
[I2024-03-21T21:29:21.958587Z 15550 0 sink.go:349] SinkServer: HTTP server stopped with "http: Server closed"
[I2024-03-21T21:29:21.958607Z 15550 0 sink_server.go:95] SinkServer: draining TestResult channel started
[I2024-03-21T21:29:22.799416Z 15550 0 sink_server.go:97] SinkServer: draining TestResult channel ended
[I2024-03-21T21:29:22.799464Z 15550 0 sink_server.go:99] SinkServer: draining Artifact channel started
[I2024-03-21T21:29:23.000760Z 15550 0 sink_server.go:101] SinkServer: draining Artifact channel ended
[I2024-03-21T21:29:23.000816Z 15550 0 sink.go:374] SinkServer: shutdown completed successfully
[I2024-03-21T21:29:23.000857Z 15550 0 cmd_stream.go:401] rdb-stream: exiting with 1

— watchflakes

@panjf2000
Copy link
Member

This issue should have been fixed by CL 573895.

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-03-21 09:28 linux-amd64-longtest-race net@ebc8168a go@3fefec96 x/net/http2.TestTransportUsesGoAwayDebugError_Body (log) 
==================
WARNING: DATA RACE
Write at 0x00c0009a8160 by goroutine 31745:
  golang.org/x/net/http2.(*testClientConnNetConn).Close()
      /workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:733 +0x32
  golang.org/x/net/http2.(*ClientConn).closeConn()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1086 +0x109
  golang.org/x/net/http2.(*clientConnReadLoop).cleanup.deferwrap1()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:2357 +0x33
  runtime.deferreturn()
...
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1311 +0x7e4
  golang.org/x/net/http2.(*ClientConn).RoundTrip()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1293 +0x104
  golang.org/x/net/http2.(*testClientConn).roundTrip.func2()
      /workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:420 +0xcd
  golang.org/x/net/http2.(*testSyncHooks).goRun.func1()
      /workdir/gopath/src/golang.org/x/net/http2/testsync.go:126 +0x81
==================
--- FAIL: TestTransportUsesGoAwayDebugError_Body (0.00s)
    testing.go:1398: race detected during execution of test

— watchflakes

@cherrymui
Copy link
Member Author

Closing with the assumption that it is fixed. Thanks.

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-03-21 09:28 linux-amd64-race net@ebc8168a go@7fb7acb8 x/net/http2.TestTransportUsesGoAwayDebugError_Body (log) 
==================
WARNING: DATA RACE
Write at 0x00c000390860 by goroutine 21897:
  golang.org/x/net/http2.(*testClientConnNetConn).Close()
      /workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:733 +0x32
  golang.org/x/net/http2.(*ClientConn).closeConn()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1086 +0x109
  golang.org/x/net/http2.(*ClientConn).forgetStreamID.deferwrap1()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:2309 +0x33
  runtime.deferreturn()
...
      /workdir/gopath/src/golang.org/x/net/http2/transport_test.go:2482 +0x4c
  golang.org/x/net/http2.TestTransportUsesGoAwayDebugError_Body()
      /workdir/gopath/src/golang.org/x/net/http2/transport_test.go:2478 +0x2b
  testing.tRunner()
      /workdir/go/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /workdir/go/src/testing/testing.go:1742 +0x44
==================
--- FAIL: TestTransportUsesGoAwayDebugError_Body (0.00s)
    testing.go:1398: race detected during execution of test

— watchflakes

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-04-03 16:50 freebsd-amd64-race net@762b58d1 go@dddf0ae4 x/net/http2.TestTransportUsesGoAwayDebugError_Body (log) 
==================
WARNING: DATA RACE
Write at 0x00c00020cb00 by goroutine 22368:
  golang.org/x/net/http2.(*testClientConnNetConn).Close()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:733 +0x32
  golang.org/x/net/http2.(*ClientConn).closeConn()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/transport.go:1086 +0x109
  golang.org/x/net/http2.(*clientConnReadLoop).cleanup.deferwrap1()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/transport.go:2357 +0x33
  runtime.deferreturn()
...
      /tmp/workdir/gopath/src/golang.org/x/net/http2/transport.go:1311 +0x7e4
  golang.org/x/net/http2.(*ClientConn).RoundTrip()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/transport.go:1293 +0x104
  golang.org/x/net/http2.(*testClientConn).roundTrip.func2()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:420 +0xcd
  golang.org/x/net/http2.(*testSyncHooks).goRun.func1()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/testsync.go:126 +0x81
==================
--- FAIL: TestTransportUsesGoAwayDebugError_Body (0.00s)
    testing.go:1398: race detected during execution of test

— watchflakes

@gopherbot gopherbot reopened this Apr 3, 2024
@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Apr 3, 2024
@dmitshur dmitshur added this to the Go1.23 milestone Apr 3, 2024
@dmitshur
Copy link
Contributor

dmitshur commented Apr 3, 2024 •
edited
Loading

The two instances above were testing x/net using Go on release-branch.go1.22.

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-04-05 22:13 linux-amd64-longtest-race net@ec05fdcd go@9f3f4c64 x/net/http2.TestTransportUsesGoAwayDebugError_Body (log) 
==================
WARNING: DATA RACE
Write at 0x00c000326160 by goroutine 30382:
  golang.org/x/net/http2.(*testClientConnNetConn).Close()
      /workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:733 +0x32
  golang.org/x/net/http2.(*ClientConn).closeConn()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1099 +0x109
  golang.org/x/net/http2.(*ClientConn).forgetStreamID.deferwrap1()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:2322 +0x33
  runtime.deferreturn()
...
      /workdir/gopath/src/golang.org/x/net/http2/transport_test.go:2482 +0x4c
  golang.org/x/net/http2.TestTransportUsesGoAwayDebugError_Body()
      /workdir/gopath/src/golang.org/x/net/http2/transport_test.go:2478 +0x2b
  testing.tRunner()
      /workdir/go/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /workdir/go/src/testing/testing.go:1742 +0x44
==================
--- FAIL: TestTransportUsesGoAwayDebugError_Body (0.00s)
    testing.go:1398: race detected during execution of test

— watchflakes

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-04-05 15:01 x_net-gotip-linux-amd64-longtest-race net@b67a0f05 go@d6a3d093 x/net/http2.TestTransportUsesGoAwayDebugError_Body (log) 
=== RUN   TestTransportUsesGoAwayDebugError_Body
==================
WARNING: DATA RACE
Write at 0x00c0003de400 by goroutine 30273:
  golang.org/x/net/http2.(*testClientConnNetConn).Close()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1118125679/http2/clientconn_test.go:733 +0x32
  golang.org/x/net/http2.(*ClientConn).closeConn()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1118125679/http2/transport.go:1086 +0x109
  golang.org/x/net/http2.(*ClientConn).forgetStreamID.deferwrap1()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1118125679/http2/transport.go:2309 +0x33
...
      /home/swarming/.swarming/w/ir/x/w/targetrepo1118125679/http2/transport_test.go:2482 +0x4c
  golang.org/x/net/http2.TestTransportUsesGoAwayDebugError_Body()
      /home/swarming/.swarming/w/ir/x/w/targetrepo1118125679/http2/transport_test.go:2478 +0x2b
  testing.tRunner()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1742 +0x44
==================
    testing.go:1398: race detected during execution of test
--- FAIL: TestTransportUsesGoAwayDebugError_Body (0.00s)

— watchflakes

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-04-18 22:01 linux-amd64-race net@f95a3b3a go@dcb5de5c x/net/http2.TestTransportUsesGoAwayDebugError_Body (log) 
==================
WARNING: DATA RACE
Write at 0x00c00034a5c0 by goroutine 21855:
  golang.org/x/net/http2.(*testClientConnNetConn).Close()
      /workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:733 +0x32
  golang.org/x/net/http2.(*ClientConn).closeConn()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:1099 +0x109
  golang.org/x/net/http2.(*ClientConn).forgetStreamID.deferwrap1()
      /workdir/gopath/src/golang.org/x/net/http2/transport.go:2322 +0x33
  runtime.deferreturn()
...
      /workdir/gopath/src/golang.org/x/net/http2/transport_test.go:2482 +0x4c
  golang.org/x/net/http2.TestTransportUsesGoAwayDebugError_Body()
      /workdir/gopath/src/golang.org/x/net/http2/transport_test.go:2478 +0x2b
  testing.tRunner()
      /workdir/go/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /workdir/go/src/testing/testing.go:1742 +0x44
==================
--- FAIL: TestTransportUsesGoAwayDebugError_Body (0.00s)
    testing.go:1398: race detected during execution of test

— watchflakes

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-04-18 22:01 windows-amd64-race net@f95a3b3a go@2dddc7ef x/net/http2.TestTransportUsesGoAwayDebugError_Body (log) 
==================
WARNING: DATA RACE
Write at 0x00c0001ca4e0 by goroutine 25210:
  golang.org/x/net/http2.(*testClientConnNetConn).Close()
      C:/workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:733 +0x32
  golang.org/x/net/http2.(*ClientConn).closeConn()
      C:/workdir/gopath/src/golang.org/x/net/http2/transport.go:1099 +0x109
  golang.org/x/net/http2.(*clientConnReadLoop).cleanup.deferwrap1()
      C:/workdir/gopath/src/golang.org/x/net/http2/transport.go:2370 +0x33
  runtime.deferreturn()
...
      C:/workdir/gopath/src/golang.org/x/net/http2/transport.go:1324 +0x7e4
  golang.org/x/net/http2.(*ClientConn).RoundTrip()
      C:/workdir/gopath/src/golang.org/x/net/http2/transport.go:1306 +0x104
  golang.org/x/net/http2.(*testClientConn).roundTrip.func2()
      C:/workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:420 +0xcd
  golang.org/x/net/http2.(*testSyncHooks).goRun.func1()
      C:/workdir/gopath/src/golang.org/x/net/http2/testsync.go:126 +0x81
==================
--- FAIL: TestTransportUsesGoAwayDebugError_Body (0.00s)
    testing.go:1398: race detected during execution of test

— watchflakes

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-05-06 20:33 gotip-windows-amd64-race go@5a181c50 net/http.TestIdleConnChannelLeak/h1 (log) 
=== RUN   TestIdleConnChannelLeak/h1
==================
WARNING: DATA RACE
Write at 0x000140c6f298 by goroutine 2266:
  net/http.SetReadLoopBeforeNextReadHook()
      C:/b/s/w/ir/x/w/goroot/src/net/http/export_test.go:76 +0x2af
  net/http_test.testIdleConnChannelLeak()
      C:/b/s/w/ir/x/w/goroot/src/net/http/transport_test.go:3380 +0x1dd
  net/http_test.run[go.shape.*uint8].func1()
      C:/b/s/w/ir/x/w/goroot/src/net/http/clientserver_test.go:90 +0x18b
...
Goroutine 2244 (finished) created at:
  net/http.(*Transport).dialConn()
      C:/b/s/w/ir/x/w/goroot/src/net/http/transport.go:1874 +0x29b3
  net/http.(*Transport).dialConnFor()
      C:/b/s/w/ir/x/w/goroot/src/net/http/transport.go:1563 +0x11d
  net/http.(*Transport).startDialConnForLocked.func1()
      C:/b/s/w/ir/x/w/goroot/src/net/http/transport.go:1545 +0x3c
==================
    testing.go:1399: race detected during execution of test
--- FAIL: TestIdleConnChannelLeak/h1 (0.02s)

— watchflakes

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-05-06 16:24 linux-arm64-race net@d27919b5 go@adbfb672 x/net/http2.TestTransportUsesGoAwayDebugError_RoundTrip (log) 
==================
WARNING: DATA RACE
Write at 0x00c00029a240 by goroutine 21474:
  golang.org/x/net/http2.(*testClientConnNetConn).Close()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:733 +0x30
  golang.org/x/net/http2.(*ClientConn).closeConn()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/transport.go:1099 +0xf4
  golang.org/x/net/http2.(*clientConnReadLoop).cleanup.deferwrap1()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/transport.go:2370 +0x34
  runtime.deferreturn()
...
      /tmp/workdir/gopath/src/golang.org/x/net/http2/transport.go:1324 +0x60c
  golang.org/x/net/http2.(*ClientConn).RoundTrip()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/transport.go:1306 +0xc4
  golang.org/x/net/http2.(*testClientConn).roundTrip.func2()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/clientconn_test.go:420 +0x98
  golang.org/x/net/http2.(*testSyncHooks).goRun.func1()
      /tmp/workdir/gopath/src/golang.org/x/net/http2/testsync.go:126 +0x78
==================
--- FAIL: TestTransportUsesGoAwayDebugError_RoundTrip (0.00s)
    testing.go:1398: race detected during execution of test

— watchflakes

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-05-07 18:38 gotip-windows-amd64-race go@008cc58a net/http.TestIdleConnChannelLeak/h1 (log) 
=== RUN   TestIdleConnChannelLeak/h1
==================
WARNING: DATA RACE
Write at 0x000140c73298 by goroutine 2329:
  net/http.SetReadLoopBeforeNextReadHook()
      C:/b/s/w/ir/x/w/goroot/src/net/http/export_test.go:76 +0x2af
  net/http_test.testIdleConnChannelLeak()
      C:/b/s/w/ir/x/w/goroot/src/net/http/transport_test.go:3380 +0x1dd
  net/http_test.run[go.shape.*uint8].func1()
      C:/b/s/w/ir/x/w/goroot/src/net/http/clientserver_test.go:90 +0x18b
...
Goroutine 2307 (finished) created at:
  net/http.(*Transport).dialConn()
      C:/b/s/w/ir/x/w/goroot/src/net/http/transport.go:1874 +0x29b3
  net/http.(*Transport).dialConnFor()
      C:/b/s/w/ir/x/w/goroot/src/net/http/transport.go:1563 +0x11d
  net/http.(*Transport).startDialConnForLocked.func1()
      C:/b/s/w/ir/x/w/goroot/src/net/http/transport.go:1545 +0x3c
==================
    testing.go:1399: race detected during execution of test
--- FAIL: TestIdleConnChannelLeak/h1 (0.03s)

— watchflakes

@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- ((pkg == "net/http" || pkg == "golang.org/x/net/http2") && (`WARNING: DATA RACE` || `race detected during execution of test`)) ||
	(mode == "build" && log ~ `race detected during execution of test` && log ~ `FAIL	net/http`)
2024-05-14 19:41 gotip-linux-arm64-race go@eef288da net/http.TestIdleConnChannelLeak/h1 (log) 
=== RUN   TestIdleConnChannelLeak/h1
==================
WARNING: DATA RACE
Write at 0x000000b28948 by goroutine 2408:
  net/http.SetReadLoopBeforeNextReadHook()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/net/http/export_test.go:76 +0x208
  net/http_test.testIdleConnChannelLeak()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/net/http/transport_test.go:3380 +0x16c
  net/http_test.run[go.shape.*uint8].func1()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/net/http/clientserver_test.go:90 +0x174
...
Goroutine 2386 (finished) created at:
  net/http.(*Transport).dialConn()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/net/http/transport.go:1874 +0x1e4c
  net/http.(*Transport).dialConnFor()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/net/http/transport.go:1563 +0xb8
  net/http.(*Transport).startDialConnForLocked.func1()
      /home/swarming/.swarming/w/ir/x/w/goroot/src/net/http/transport.go:1545 +0x38
==================
    testing.go:1399: race detected during execution of test
--- FAIL: TestIdleConnChannelLeak/h1 (0.01s)

— watchflakes

@neild neild self-assigned this Jul 31, 2024
@gopherbot gopherbot modified the milestones: Go1.23, Go1.24 Aug 13, 2024
@gopherbot gopherbot modified the milestones: Go1.24, Go1.25 Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neild neild

Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Done
Milestone
Go1.25
Development

No branches or pull requests
5 participants
@neild @dmitshur @panjf2000 @gopherbot @cherrymui