Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: Deprecation annotation for packages isn't displayed #66574

Open
johannes-riecken opened this issue Mar 28, 2024 · 3 comments
Open

Comments

@johannes-riecken
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/google.golang.org/api@v0.171.0/sql/v1beta4

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:99.0) Gecko/20100101 Firefox/99.0

What did you do?

I opened the page above.

What did you expect to see?

A prominent deprecation warning next to the package description. I expect this, because the package comment for the source file starts with "// Deprecated: ".

What did you see instead?

No mention of the package being deprecated.

@gopherbot gopherbot added this to the Unreleased milestone Mar 28, 2024
@suzmue suzmue modified the milestones: Unreleased, pkgsite/backlog Mar 28, 2024
@jfrech
Copy link

jfrech commented Apr 4, 2024

No mention of the package being deprecated.

My browser renders the deprecation paragraph at the very end of the "Overview" section, behaving analogous to e. g. https://pkg.go.dev/io/ioutil.

@johannes-riecken
Copy link
Author

No mention of the package being deprecated.

My browser renders the deprecation paragraph at the very end of the "Overview" section, behaving analogous to e. g. https://pkg.go.dev/io/ioutil.

Oh, my bad, I must have missed that. I'd prefer having it more visually prominent though, as it's easy to miss.

@jfrech
Copy link

jfrech commented Apr 4, 2024

I would agree: a beige background -- as is done with deprecated functions -- around the "Deprecated:" paragraph I would welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants