strings: Replacer fails at beginning of string

[robpike]

package main

import(
    "fmt"
    "strings"
)

func main(){
    fmt.Println(strings.NewReplacer("Hello", "").Replace("Hellox"))
    fmt.Println(strings.NewReplacer("Hello", "").Replace("xHellox"))
}

Prints

Hellox
xx

[bradfitz]

Comment 1:

Broken starting at:
changeset:   14462:0a0a751f0b74
user:        Eric Roshan-Eisner <eric.d.eisner@gmail.com>
date:        Fri Sep 28 12:34:18 2012 +1000
summary:     strings: implement a faster single-string Replacer
Work-around fix:
diff -r 7ebbddd21330 src/pkg/strings/replace.go
--- a/src/pkg/strings/replace.go    Thu Oct 24 10:13:23 2013 -0700
+++ b/src/pkg/strings/replace.go    Thu Oct 24 15:06:56 2013 -0700
@@ -34,7 +34,7 @@
    }
 
    if len(oldnew) == 2 && len(oldnew[0]) > 1 {
-       return &Replacer{r: makeSingleStringReplacer(oldnew[0], oldnew[1])}
+//     return &Replacer{r: makeSingleStringReplacer(oldnew[0], oldnew[1])}
    }
 
Looking into it.

[robpike]

Comment 2:

Issue #6660 has been merged into this issue.

[bradfitz]

Comment 3:

Sent https://golang.org/cl/16880043

Status changed to Started.

[bradfitz]

Comment 4:

This issue was closed by revision 2d6a139.

Status changed to Fixed.

[adg]

Comment 5:

This issue was closed by revision 0883b7d7a008.