Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: optimize use of method sets #6669

Closed
griesemer opened this issue Oct 25, 2013 · 4 comments
Closed

go/types: optimize use of method sets #6669

griesemer opened this issue Oct 25, 2013 · 4 comments
Assignees
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Oct 25, 2013

- method sets should always compute both the set for a type T and *T
- method sets should be used for some of the internal lookup operations
- method sets should be computed at most once
@rsc
Copy link
Contributor

@rsc rsc commented Nov 27, 2013

Comment 1:

Labels changed: added go1.3maybe.

Loading

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 2:

Labels changed: added release-none, removed go1.3maybe.

Loading

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 3:

Labels changed: added repo-tools.

Loading

@griesemer griesemer self-assigned this Dec 4, 2013
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title go.tools/go/types: optimize use of method sets x/tools/go/types: optimize use of method sets Apr 14, 2015
@rsc rsc added this to the Unreleased milestone Apr 14, 2015
@rsc rsc removed this from the Unplanned milestone Apr 14, 2015
@rsc rsc removed the repo-tools label Apr 14, 2015
@griesemer griesemer added this to the Unplanned milestone Jun 23, 2015
@griesemer griesemer removed this from the Unreleased milestone Jun 23, 2015
@griesemer griesemer changed the title x/tools/go/types: optimize use of method sets go/types: optimize use of method sets Jun 23, 2015
@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Dec 20, 2017

Closing due to age. If there's an actual performance issue we would have seen it by now.

Loading

@griesemer griesemer closed this Dec 20, 2017
@golang golang locked and limited conversation to collaborators Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants