Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/cgo: clang rejects -fno-eliminate-unused-debug-types on Mavericks #6678

Closed
gopherbot opened this issue Oct 28, 2013 · 7 comments

Comments

@gopherbot
Copy link

commented Oct 28, 2013

by gmacr31:

Try:
go get -u github.com/moovweb/gokogiri

What is the expected output?
Nothing, it should fetch my desired go pkg

What do you see instead?
Error message:
# github.com/moovweb/gokogiri/xpath
clang: error: argument unused during compilation: '-fno-eliminate-unused-debug-types'

Which compiler are you using (5g, 6g, 8g, gccgo)?
6g

Which operating system are you using?
OS X Mavericks (10.9)

Which version are you using?  (run 'go version')
go version go1.2rc2 darwin/amd64

Please provide any additional information below.
I have gokogiri installed already, however, I get the same error when I compile any code
with that dependency.
@rsc

This comment has been minimized.

Copy link
Contributor

commented Oct 28, 2013

Comment 1:

Status changed to Acceptd.

@rsc

This comment has been minimized.

Copy link
Contributor

commented Oct 28, 2013

Comment 2:

Labels changed: added priority-later, go1.2, removed priority-triage.

Status changed to Accepted.

@dominikh

This comment has been minimized.

Copy link
Member

commented Oct 28, 2013

Comment 4:

Isn't this a duplicate of issue #6515 and fixed on tip?
@dominikh

This comment has been minimized.

Copy link
Member

commented Oct 28, 2013

Comment 5:

Which of course conflicts with the Go version reported by OP…
@gopherbot

This comment has been minimized.

Copy link
Author

commented Oct 28, 2013

Comment 6 by gmacr31:

Haha no worries. Yeah I think this issue persists.
Sorry about that
@rsc

This comment has been minimized.

Copy link
Contributor

commented Oct 29, 2013

Comment 7:

This issue was closed by revision adda334.

Status changed to Fixed.

@adg

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2013

Comment 8:

This issue was closed by revision 6f62370a69e3.

@gopherbot gopherbot added fixed labels Nov 1, 2013

@rsc rsc added this to the Go1.2 milestone Apr 14, 2015

@rsc rsc removed the go1.2 label Apr 14, 2015

adg added a commit that referenced this issue May 11, 2015
[release-branch.go1.2] cmd/cgo: stop using -fno-eliminate-unused-debu…
…g-types

««« CL 18850043 / 5ef4bf9eb256
cmd/cgo: stop using -fno-eliminate-unused-debug-types

This flag was added in January 2010, in CL 181102, to fix issue 497.
(Numbers were just shorter back then.) The fix was for OS X machines
and the llvm-gcc frontend.

In July 2011 we had to change the way we get enum values, because
there were no flags available to force Xcode's llvm-gcc to include the
enum names and values in DWARF debug output.

We now use clang, not llvm-gcc, on OS X machines.
Earlier versions of clang printed a warning about not knowing the flag.
Newer versions of clang now make that an error.

That is:
 - The flag was added for OS X machines.
 - The flag is no longer necessary on OS X machines.
 - The flag now breaks some OS X machines.

Remove it.

I have run the original program from issue 497 successfully
without the flag on both OS X and Linux machines.

Fixes #6678.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/18850043
»»»

R=golang-dev
CC=golang-dev
https://golang.org/cl/19850048

@golang golang locked and limited conversation to collaborators Jun 25, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.