Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: bogo suite on Windows is flakey #66913

Open
rolandshoemaker opened this issue Apr 19, 2024 · 3 comments
Open

crypto/tls: bogo suite on Windows is flakey #66913

rolandshoemaker opened this issue Apr 19, 2024 · 3 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows

Comments

@rolandshoemaker
Copy link
Member

See e.g. https://ci.chromium.org/ui/p/golang/builders/ci/gotip-windows-amd64-longtest/b8750306255775534897/test-results?sortby=&groupby=

Seems like another case of Windows just not liking creating a lot of connections, unclear what a real solution here is. Probably just disabling it on windows builders?
@rolandshoemaker rolandshoemaker added OS-Windows NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Apr 19, 2024
@matloob
Copy link
Contributor

matloob commented Apr 23, 2024

I think it would be a good idea to skip it on Windows for now.

@rolandshoemaker
Copy link
Member Author

Yup, will send a CL. I have a possible plan to make bogo skip the network stack entirely and use in-memory connections, but that will require a bunch of work in boringssl.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/581515 mentions this issue: crypto/tls: skip bogo suite on windows builders

gopherbot pushed a commit that referenced this issue Apr 24, 2024
@rolandshoemaker @gopherbot
crypto/tls: skip bogo suite on windows builders
e689118 
Updates #66913

Change-Id: Ie6bb262ee95593d23a93ef06656a561a7b1006ba
Reviewed-on: https://go-review.googlesource.com/c/go/+/581515
Auto-Submit: Roland Shoemaker <roland@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <matloob@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rolandshoemaker @gopherbot @matloob