Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet: go vet doesn't understand NOSPLIT in assembler definition #6695

Closed
ncw opened this issue Oct 30, 2013 · 2 comments

Comments

Projects
None yet
3 participants
@ncw
Copy link
Contributor

commented Oct 30, 2013

What steps will reproduce the problem?

$ cd src/pkg/crypto/md5
$ go vet                    

What is the expected output?

Nothing as this is valid assembler

$ grep TEXT md5block_amd64.s
TEXT    ·block(SB),NOSPLIT,$0-32

What do you see instead?

: md5block_amd64.s:16: [amd64] wrong argument size 0; expected $...-32

If you replace the TEXT line with

TEXT    ·block(SB),7,$0-32

Then go vet ceases to complain, probably indicating it doesn't understand the NOSPLIT
#define

Which compiler are you using (5g, 6g, 8g, gccgo)?

6g

Which operating system are you using?

linux/amd64

Which version are you using?  (run 'go version')

go version devel +746466b52725 Wed Oct 30 08:54:53 2013 -0700 linux/amd64

Please provide any additional information below.

Fresh version of go tools fetched with

go get code.google.com/p/go.tools/cmd/vet

src/code.google.com/p/go.tools$ hg summary
parent: 410:60eb0bc2b915 tip
 go.tools: clear DeclarationErrors flag; it's redundant w.r.t go/types checking.
branch: default
commit: (clean)
update: (current)
@robpike

This comment has been minimized.

Copy link
Contributor

commented Oct 30, 2013

Comment 1:

Labels changed: added priority-soon, toolbug, removed priority-triage.

Owner changed to @robpike.

Status changed to Accepted.

@robpike

This comment has been minimized.

Copy link
Contributor

commented Nov 1, 2013

Comment 2:

This issue was closed by revision golang/tools@2afbb1c.

Status changed to Fixed.

@ncw ncw added fixed labels Nov 1, 2013

@golang golang locked and limited conversation to collaborators Jun 25, 2016

This issue was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.