net/http: document that closing a http.Response.Body without first reading it closes the connection

[schmichael]

tl;dr - summarize http://golang.org/src/pkg/net/http/transport.go#L942 in the
http.Response.Body docs: http://tip.golang.org/pkg/net/http/#Response

Perhaps: "Calling Body.Close() before reading the entire response will cause the
underlying connection to be closed."

What steps will reproduce the problem?

http://play.golang.org/p/ue3kwSEb37 (Requires net/http.Get so you have to copy it
locally)

What is the expected output?

Output is as expected once you understand the importance of reading the Response.Body
before closing it.

What do you see instead?

"cannot assign requested address" due to ephemeral port exhaustion.

Which operating system are you using?

Linux / Ubuntu 13.10

Which version are you using?  (run 'go version')

1.1.1

[bradfitz]

Comment 1:

I'm not sure what we would say or want to guarantee here.
Any wording I can think of sounds too low-level or locks us into a certain behavior
forever.

Status changed to Thinking.

[rsc]

Comment 2:

Labels changed: added go1.3maybe.

[rsc]

Comment 3:

Labels changed: added release-none, removed go1.3maybe.

[rsc]

Comment 4:

Labels changed: added repo-main.

[gopherbot]

Comment 5 by julien.laffaye:

Shouldnt Body.Close() call io.Copy with ioutil.Discard, if the internals of http package
require it ?

[bradfitz]

Comment 6:

It used to do that, but that was more problematic. There might be a multi-GB post body
coming. In that case it's better to close the connection.
In any case, this is all a detail that the user shouldn't care about. In HTTP/2 it's
totally different too. Documenting anything in particular seems misleading.

Status changed to WontFix.