Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: make Hover display std version information #67159

Open
adonovan opened this issue May 3, 2024 · 1 comment
Open

x/tools/gopls: make Hover display std version information #67159

adonovan opened this issue May 3, 2024 · 1 comment
Labels
FeatureRequest gopls Issues related to the Go language server, gopls.
Milestone

Comments

@adonovan
Copy link
Member

adonovan commented May 3, 2024

While solving #46136 by adding a new analyzers, stdversion, we created an internal helper package https://pkg.go.dev/golang.org/x/tools/internal/stdlib that contains a manifest of all std symbols and their versions.
We should use this information in Completions, to ensure that only version-appropriate completions are offered;
and in Hover, to report the initial Go version for each std symbol. And perhaps other places as well.

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 3, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 3, 2024
@adonovan adonovan added FeatureRequest and removed Tools This label describes issues relating to any tools in the x/tools repository. labels May 3, 2024
@adonovan adonovan modified the milestones: Unreleased, gopls/v0.16.0 May 3, 2024
@adonovan
Copy link
Member Author

adonovan commented May 3, 2024

On closer inspection, apparently I already added version support to completion. So that leaves just Hover.

@adonovan adonovan changed the title x/tools/gopls: make completion, hover use std version information x/tools/gopls: make Hover display std version information May 3, 2024
@findleyr findleyr modified the milestones: gopls/v0.16.0, gopls/v0.17.0 May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FeatureRequest gopls Issues related to the Go language server, gopls.
Projects
None yet
Development

No branches or pull requests

3 participants