Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/build: modify contents of "gray box" (summary markdown) in LUCI UI to be more directly to the point for test failures #67165

Open
mknyszek opened this issue May 3, 2024 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) DevExp anything around developer experience NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@mknyszek
Copy link
Contributor

mknyszek commented May 3, 2024

Currently the LUCI UI for Go builds isn't very direct, especially in the common case of a test failure.

For example:
image

The "FAILURE" line is redundant, the "exit status 1" line is also not very useful (more useful for an infra failure, less useful for a test failure), and the "Links" section has only one link that goes to a more verbose set of information. Nowhere here do we link to the test results directly (we do for main Go repo builds, but that also includes less useful information, like the shard number).

@rsc proposed including a summary of the test failure text instead, which I believe is the right call. We already plumb around the fact that a test failed anyway.

I'll defend the existence of the go on <x> and website on <y> lines, because I don't believe that information is surfaced very well anywhere else in the UI, but other than that, the summary markdown could use a rethink.

@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label May 3, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 3, 2024
@rsc
Copy link
Contributor

rsc commented May 6, 2024

On https://go-review.googlesource.com/c/go/+/583455 PS1:

Can these URLs be changed to https://ci.chromium.org/ui/p/golang/builders/try/gotip-linux-386/b8748684851461439681/test-results instead?

You showed me how to change the default behavior to not go to the Overview page, but we know the Test Results are the right landing page for users viewing a failure on a Gerrit page. Let's link directly there, so that we don't have to train everyone to change their defaults. (If everyone has to change their defaults, the defaults are wrong.)

@rsc
Copy link
Contributor

rsc commented May 6, 2024

For the record, these are the magic places to click to get one-click viewing of test results.

LUCI-Clicks

The first time you click on one of those, you have to also edit your LUCI config to default to "Test Results":

LUCI-Config

Editing the config works even if you are not logged in. It stores the result in Local Storage. Mine says:

{"id":...,"build":{"steps":{"elideSucceededSteps":true,"showDebugLogs":false,"expandByDefault":1,"_pinnedSteps":{"_values":{}}},"inputProperties":{"_foldedRootKeys":{"_values":{}}},"outputProperties":{"_foldedRootKeys":{"_values":{}}},"defaultTab":"test-results"},"tests":{"_columnWidths":{"v.test_suite":350}}}

@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label May 6, 2024
@dmitshur dmitshur added the DevExp anything around developer experience label May 6, 2024
@mknyszek
Copy link
Contributor Author

FYI, I'm landing a few CLs that should improve the state of things here. They are:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builders x/build issues (builders, bots, dashboards) DevExp anything around developer experience NeedsFix The path to resolution is known, but the work has not been done.
Projects
Status: In Progress
Development

No branches or pull requests

5 participants