Skip to content

x/website: dark background of images in chacha8rand blog post #67224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Deleplace opened this issue May 7, 2024 · 4 comments
Closed

x/website: dark background of images in chacha8rand blog post #67224

Deleplace opened this issue May 7, 2024 · 4 comments
Labels
website
Milestone
website/backlog

Comments

@Deleplace
Copy link
Contributor

Go version

N/A

Output of go env in your module/workspace:

N/A

What did you do?

https://go.dev/blog/chacha8rand#performance

What did you see happen?

image

What did you expect to see?

Better contrast in the 7 SVG images:

  • either light color over dark background (best)
  • or dark color over light background
@gopherbot gopherbot added this to the Unreleased milestone May 7, 2024
@Deleplace
Copy link
Contributor Author

Observed in (Chrome, macOS) and (Firefox, macOS)

@suzmue suzmue modified the milestones: Unreleased, website/backlog May 7, 2024
@cherrymui
Copy link
Member

cc @rsc @FiloSottile @golang/tools-team

@cherrymui cherrymui added the NeedsFix The path to resolution is known, but the work has not been done. label May 7, 2024
@mauri870 mauri870 added help wanted and removed help wanted NeedsFix The path to resolution is known, but the work has not been done. labels May 15, 2024
@mauri870
Copy link
Member

Looks like it is fixed by CL 583835, so closing.

@Deleplace
Copy link
Contributor Author

Yes, I confirm :)

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
website
Projects
None yet
Milestone
website/backlog
Development

No branches or pull requests
5 participants
@suzmue @gopherbot @mauri870 @Deleplace @cherrymui