Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/misc: TestRenderNoPanic66449/default failures #67443

Closed
gopherbot opened this issue May 16, 2024 · 4 comments
Closed

x/tools/gopls/internal/test/integration/misc: TestRenderNoPanic66449/default failures #67443

gopherbot opened this issue May 16, 2024 · 4 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRenderNoPanic66449/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestRenderNoPanic66449/default
    webserver_test.go:176: showDocument(package doc) URL: http://127.0.0.1:49335/gopls/udDw7eof15A/pkg/example.com/a?view=155
    webserver_test.go:120: input matched unwanted pattern "f1"; got:
        <!DOCTYPE html>
        <html>
        <head>
          <meta charset="UTF-8">
          <style>
        body {
          font-family: Helvetica, Arial, sans-serif;
...
[Trace - 14:03:05.777 PM] Sending response 'window/showDocument - (7)' in 0ms.
Result: {"success":true}


[Trace - 14:03:05.777 PM] Received response 'workspace/executeCommand - (3)' in 0ms.
Result: null


#### End Gopls Test Logs for "TestRenderNoPanic66449/default"
--- FAIL: TestRenderNoPanic66449/default (0.05s)

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 16, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 16, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRenderNoPanic66449/default"
2024-04-02 20:54 x_tools-go1.21-darwin-arm64_11 tools@0a4fc723 release-branch.go1.21@30d85506 x/tools/gopls/internal/test/integration/misc.TestRenderNoPanic66449/default (log) 
=== RUN   TestRenderNoPanic66449/default
    webserver_test.go:176: showDocument(package doc) URL: http://127.0.0.1:49335/gopls/udDw7eof15A/pkg/example.com/a?view=155
    webserver_test.go:120: input matched unwanted pattern "f1"; got:
        <!DOCTYPE html>
        <html>
        <head>
          <meta charset="UTF-8">
          <style>
        body {
          font-family: Helvetica, Arial, sans-serif;
...
[Trace - 14:03:05.777 PM] Sending response 'window/showDocument - (7)' in 0ms.
Result: {"success":true}


[Trace - 14:03:05.777 PM] Received response 'workspace/executeCommand - (3)' in 0ms.
Result: null


#### End Gopls Test Logs for "TestRenderNoPanic66449/default"
--- FAIL: TestRenderNoPanic66449/default (0.05s)
2024-04-02 20:54 x_tools-go1.21-linux-amd64-boringcrypto tools@0a4fc723 release-branch.go1.21@30d85506 x/tools/gopls/internal/test/integration/misc.TestRenderNoPanic66449/default (log) 
=== RUN   TestRenderNoPanic66449/default
    webserver_test.go:176: showDocument(package doc) URL: http://127.0.0.1:40393/gopls/1wf1EyC72Gc/pkg/example.com/a?view=155
    webserver_test.go:120: input matched unwanted pattern "f1"; got:
        <!DOCTYPE html>
        <html>
        <head>
          <meta charset="UTF-8">
          <style>
        body {
          font-family: Helvetica, Arial, sans-serif;
...
[Trace - 21:00:57.280 PM] Sending response 'window/showDocument - (7)' in 0ms.
Result: {"success":true}


[Trace - 21:00:57.280 PM] Received response 'workspace/executeCommand - (3)' in 0ms.
Result: null


#### End Gopls Test Logs for "TestRenderNoPanic66449/default"
--- FAIL: TestRenderNoPanic66449/default (0.05s)
2024-04-02 20:54 x_tools-go1.21-darwin-arm64_11 tools@222cddee release-branch.go1.21@30d85506 x/tools/gopls/internal/test/integration/misc.TestRenderNoPanic66449/default (log) 
=== RUN   TestRenderNoPanic66449/default
    webserver_test.go:176: showDocument(package doc) URL: http://127.0.0.1:52485/gopls/V1zNdbt1Hu4/pkg/example.com/a?view=155
    webserver_test.go:122: input matched unwanted pattern "t1"; got:
        <!DOCTYPE html>
        <html>
        <head>
          <meta charset="UTF-8">
          <style>
        body {
          font-family: Helvetica, Arial, sans-serif;
...
[Trace - 13:59:08.951 PM] Sending response 'window/showDocument - (7)' in 0ms.
Result: {"success":true}


[Trace - 13:59:08.951 PM] Received response 'workspace/executeCommand - (3)' in 0ms.
Result: null


#### End Gopls Test Logs for "TestRenderNoPanic66449/default"
--- FAIL: TestRenderNoPanic66449/default (0.07s)
2024-04-03 14:07 x_tools-go1.21-openbsd-amd64 tools@53d35a51 release-branch.go1.21@ae591334 x/tools/gopls/internal/test/integration/misc.TestRenderNoPanic66449/default (log) 
=== RUN   TestRenderNoPanic66449/default
    webserver_test.go:176: showDocument(package doc) URL: http://127.0.0.1:1616/gopls/OxDf1Ax56Hw/pkg/example.com/a?view=155
    webserver_test.go:120: input matched unwanted pattern "f1"; got:
        <!DOCTYPE html>
        <html>
        <head>
          <meta charset="UTF-8">
          <style>
        body {
          font-family: Helvetica, Arial, sans-serif;
...
[Trace - 08:42:12.942 AM] Sending response 'window/showDocument - (7)' in 0ms.
Result: {"success":true}


[Trace - 08:42:12.943 AM] Received response 'workspace/executeCommand - (3)' in 1ms.
Result: null


#### End Gopls Test Logs for "TestRenderNoPanic66449/default"
--- FAIL: TestRenderNoPanic66449/default (0.53s)
2024-04-03 18:28 x_tools-go1.21-windows-amd64-race tools@f345449c release-branch.go1.21@74501172 x/tools/gopls/internal/test/integration/misc.TestRenderNoPanic66449/default (log) 
=== RUN   TestRenderNoPanic66449/default
    webserver_test.go:176: showDocument(package doc) URL: http://127.0.0.1:50383/gopls/mCUZtWCKf1U/pkg/example.com/a?view=155
    webserver_test.go:120: input matched unwanted pattern "f1"; got:
        <!DOCTYPE html>
        <html>
        <head>
          <meta charset="UTF-8">
          <style>
        body {
          font-family: Helvetica, Arial, sans-serif;
...
[Trace - 11:47:20.266 AM] Sending response 'window/showDocument - (7)' in 3ms.
Result: {"success":true}


[Trace - 11:47:20.267 AM] Received response 'workspace/executeCommand - (3)' in 3ms.
Result: null


#### End Gopls Test Logs for "TestRenderNoPanic66449/default"
--- FAIL: TestRenderNoPanic66449/default (0.50s)
2024-04-03 23:06 x_tools-gotip-darwin-amd64_14 tools@c9b0c65f go@23fc9170 x/tools/gopls/internal/test/integration/misc.TestRenderNoPanic66449/default (log) 
=== RUN   TestRenderNoPanic66449/default
    webserver_test.go:176: showDocument(package doc) URL: http://127.0.0.1:54751/gopls/nBMdlt1I1E4/pkg/example.com/a?view=155
    webserver_test.go:122: input matched unwanted pattern "t1"; got:
        <!DOCTYPE html>
        <html>
        <head>
          <meta charset="UTF-8">
          <style>
        body {
          font-family: Helvetica, Arial, sans-serif;
...
[Trace - 18:18:20.771 PM] Sending response 'window/showDocument - (7)' in 0ms.
Result: {"success":true}


[Trace - 18:18:20.772 PM] Received response 'workspace/executeCommand - (3)' in 0ms.
Result: null


#### End Gopls Test Logs for "TestRenderNoPanic66449/default"
--- FAIL: TestRenderNoPanic66449/default (1.51s)

— watchflakes

@findleyr
Copy link
Contributor

CC @adonovan

@findleyr
Copy link
Contributor

Ah, fixed by https://go.dev/cl/576140.

Watchflakes bug?

@adonovan
Copy link
Member

Watchflakes bug?

Possibly. There have been a handful of dups for this particular test failure.

@gabyhelp gabyhelp mentioned this issue Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@adonovan @gopherbot @findleyr