Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/misc: TestRenderNoPanic66449/experimental failures #67444

Closed
gopherbot opened this issue May 16, 2024 · 2 comments
Closed

x/tools/gopls/internal/test/integration/misc: TestRenderNoPanic66449/experimental failures #67444

gopherbot opened this issue May 16, 2024 · 2 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link
Contributor 

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRenderNoPanic66449/experimental"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestRenderNoPanic66449/experimental
    webserver_test.go:176: showDocument(package doc) URL: http://127.0.0.1:46499/gopls/DvCWfKbt1F4/pkg/example.com/a?view=407
    webserver_test.go:122: input matched unwanted pattern "t1"; got:
        <!DOCTYPE html>
        <html>
        <head>
          <meta charset="UTF-8">
          <style>
        body {
          font-family: Helvetica, Arial, sans-serif;
...
[Trace - 21:07:47.932 PM] Sending response 'window/showDocument - (7)' in 1ms.
Result: {"success":true}


[Trace - 21:07:47.933 PM] Received response 'workspace/executeCommand - (3)' in 2ms.
Result: null


#### End Gopls Test Logs for "TestRenderNoPanic66449/experimental"
--- FAIL: TestRenderNoPanic66449/experimental (0.08s)

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 16, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 16, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestRenderNoPanic66449/experimental"
2024-04-02 20:54 x_tools-go1.21-linux-amd64-longtest-race tools@0a4fc723 release-branch.go1.21@30d85506 x/tools/gopls/internal/test/integration/misc.TestRenderNoPanic66449/experimental (log) 
=== RUN   TestRenderNoPanic66449/experimental
    webserver_test.go:176: showDocument(package doc) URL: http://127.0.0.1:46499/gopls/DvCWfKbt1F4/pkg/example.com/a?view=407
    webserver_test.go:122: input matched unwanted pattern "t1"; got:
        <!DOCTYPE html>
        <html>
        <head>
          <meta charset="UTF-8">
          <style>
        body {
          font-family: Helvetica, Arial, sans-serif;
...
[Trace - 21:07:47.932 PM] Sending response 'window/showDocument - (7)' in 1ms.
Result: {"success":true}


[Trace - 21:07:47.933 PM] Received response 'workspace/executeCommand - (3)' in 2ms.
Result: null


#### End Gopls Test Logs for "TestRenderNoPanic66449/experimental"
--- FAIL: TestRenderNoPanic66449/experimental (0.08s)
2024-04-03 18:28 x_tools-go1.21-linux-386-longtest tools@f345449c release-branch.go1.21@74501172 x/tools/gopls/internal/test/integration/misc.TestRenderNoPanic66449/experimental (log) 
=== RUN   TestRenderNoPanic66449/experimental
    webserver_test.go:176: showDocument(package doc) URL: http://127.0.0.1:32925/gopls/LpfTn0f1irs/pkg/example.com/a?view=407
    webserver_test.go:120: input matched unwanted pattern "f1"; got:
        <!DOCTYPE html>
        <html>
        <head>
          <meta charset="UTF-8">
          <style>
        body {
          font-family: Helvetica, Arial, sans-serif;
...
[Trace - 18:40:20.556 PM] Sending response 'window/showDocument - (7)' in 0ms.
Result: {"success":true}


[Trace - 18:40:20.556 PM] Received response 'workspace/executeCommand - (3)' in 0ms.
Result: null


#### End Gopls Test Logs for "TestRenderNoPanic66449/experimental"
--- FAIL: TestRenderNoPanic66449/experimental (0.05s)
2024-04-03 19:36 x_tools-go1.21-linux-amd64-longtest tools@c623a281 release-branch.go1.21@74501172 x/tools/gopls/internal/test/integration/misc.TestRenderNoPanic66449/experimental (log) 
=== RUN   TestRenderNoPanic66449/experimental
    webserver_test.go:176: showDocument(package doc) URL: http://127.0.0.1:42921/gopls/rIUt1NNVtOg/pkg/example.com/a?view=407
    webserver_test.go:122: input matched unwanted pattern "t1"; got:
        <!DOCTYPE html>
        <html>
        <head>
          <meta charset="UTF-8">
          <style>
        body {
          font-family: Helvetica, Arial, sans-serif;
...
[Trace - 19:48:41.793 PM] Sending response 'window/showDocument - (7)' in 0ms.
Result: {"success":true}


[Trace - 19:48:41.793 PM] Received response 'workspace/executeCommand - (3)' in 1ms.
Result: null


#### End Gopls Test Logs for "TestRenderNoPanic66449/experimental"
--- FAIL: TestRenderNoPanic66449/experimental (0.06s)

— watchflakes

@adonovan
Copy link
Member

This was fixed 6 weeks ago by https://go.dev/cl/576140.

@gabyhelp gabyhelp mentioned this issue Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@adonovan @gopherbot