Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: add ConnectionState.CurveID #67516

Open
FiloSottile opened this issue May 19, 2024 · 4 comments
Open

crypto/tls: add ConnectionState.CurveID #67516

FiloSottile opened this issue May 19, 2024 · 4 comments
Labels
Proposal Proposal-Accepted Proposal-Crypto Proposal related to crypto packages or other security issues
Milestone

Comments

@FiloSottile
Copy link
Contributor

Proposal Details

With #67061, the selected "CurveID" is the difference between a post-quantum connection and not. We should expose it in ConnectionState. I actually assumed we were already exposing this.

It's unfortunate to use the CurveID misnomer, but ConnectionState doesn't feel like the place to start introducing a new name, it will only cause confusion.

/cc @golang/security

@FiloSottile FiloSottile added Proposal Proposal-Crypto Proposal related to crypto packages or other security issues labels May 19, 2024
@gopherbot gopherbot added this to the Proposal milestone May 19, 2024
@FiloSottile
Copy link
Contributor Author

If a deprecated RSA KEX is used, CurveID will be zero.

@rsc
Copy link
Contributor

rsc commented Aug 14, 2024

This proposal has been added to the active column of the proposals project
and will now be reviewed at the weekly proposal review meetings.
— rsc for the proposal review group

@rsc
Copy link
Contributor

rsc commented Aug 29, 2024

Based on the discussion above, this proposal seems like a likely accept.
— rsc for the proposal review group

The proposal is to add a CurveID field of type tls.CurveID to tls.ConnectionState.

@rsc
Copy link
Contributor

rsc commented Sep 4, 2024

No change in consensus, so accepted. 🎉
This issue now tracks the work of implementing the proposal.
— rsc for the proposal review group

The proposal is to add a CurveID field of type tls.CurveID to tls.ConnectionState.

@rsc rsc changed the title proposal: crypto/tls: add ConnectionState.CurveID crypto/tls: add ConnectionState.CurveID Sep 4, 2024
@rsc rsc modified the milestones: Proposal, Backlog Sep 4, 2024
@dmitshur dmitshur modified the milestones: Backlog, Go1.24 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Proposal Proposal-Accepted Proposal-Crypto Proposal related to crypto packages or other security issues
Projects
Status: Accepted
Development

No branches or pull requests

4 participants