Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: package removal request for github.com/flc1125/go-twca/mid #67567

Closed
flc1125 opened this issue May 22, 2024 · 8 comments
Closed

x/pkgsite: package removal request for github.com/flc1125/go-twca/mid #67567

flc1125 opened this issue May 22, 2024 · 8 comments
Assignees
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Milestone

Comments

@flc1125
Copy link

flc1125 commented May 22, 2024

I accidentally published: github.com/flc1125/go-twca/mid, but what I actually want to keep is: github.com/flc1125/go-twca. So please help me delete: github.com/flc1125/go-twca/mid.

I am the owner of the repository, which can be verified through the address.

Thank you very much.

@gopherbot gopherbot added this to the Unreleased milestone May 22, 2024
@flc1125 flc1125 changed the title x/pkgsite: package removal request for https://pkg.go.dev/github.com/flc1125/go-twca/mid x/pkgsite: package removal request for github.com/flc1125/go-twca/mid May 22, 2024
@seankhliao seankhliao added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label May 22, 2024
@hyangah
Copy link
Contributor

hyangah commented May 23, 2024

@jba Is it currently feasible to hide github.com/flc1125/go-twca/mid (module), but leave github.com/flc1125/go-twca/mid (pkg of github.com/flc1125/go-twca@v1.0.5)?

@hyangah hyangah added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 23, 2024
@jba
Copy link
Contributor

jba commented May 23, 2024

No. Exclusions are based on path prefix.

@ansaba ansaba self-assigned this May 30, 2024
@ansaba
Copy link

ansaba commented May 30, 2024

@flc1125 , it will exclude all the child packages of /flc1125/go-twca/mid also from pkgsite. Is it what you intend ?

@flc1125
Copy link
Author

flc1125 commented May 31, 2024

Yes, or if there is anything I need to do that would be more convenient to operate, you can also tell me. @ansaba

@suzmue
Copy link
Contributor

suzmue commented May 31, 2024

Hi @flc1125!

So just to clarify, if we remove the documentation for https://pkg.go.dev/github.com/flc1125/go-twca/mid it will also get rid of the documentation for https://pkg.go.dev/github.com/flc1125/go-twca@v1.0.5/mid (and all other versions of this package). If that works for you we can just delete the documentation for both of these, but the go command will still be able to see both packages.

If you do want to have users for https://pkg.go.dev/github.com/flc1125/go-twca@v1.0.5/mid, you probably will want to retract all versions of https://pkg.go.dev/github.com/flc1125/go-twca/mid. I can see that the module proxy has a copy of v1.0.0 for module github.com/flc1125/go-twca/mid (https://proxy.golang.org/cached-only/github.com/flc1125/go-twca/mid/@v/v1.0.0.info) and your documentation for https://pkg.go.dev/github.com/flc1125/go-twca@v1.0.5/mid links to the "latest" version, which is that module you are trying to delete. The go command prefers github.com/flc1125/go-twca/mid to github.com/flc1125/go-twca when matching on the package.

To retract all versions of github.com/flc1125/go-twca/mid, you will want to:

  1. Add back the go.mod file in github.com/flc1125/go-twca/mid.
  2. Add a retract directive to the go.mod
retract [v0.0.0-0, v1.0.1]  // assuming v1.0.1 contains this retraction.
  1. Tag mid/v1.0.1
  2. Delete the go.mod in github.com/flc1125/go-twca/mid

And that should take care of it! If you have any questions about this process or any of this didn't make sense feel free to ask.

@flc1125
Copy link
Author

flc1125 commented Jun 3, 2024

@suzmue Hello, I would like to know about this part retract [v0.0.0-0, v1.0.1], should it be added under /mid/go.mod or /go.mod? I tried placing it under /mid/go.mod, but I noticed that https://pkg.go.dev/github.com/flc1125/go-twca/mid still exists.

Sure, here is your translated text:

Here are my adjustments and the related versions:

@flc1125
Copy link
Author

flc1125 commented Jun 3, 2024

@suzmue However, I tried importing the mid package, and I found that it works correctly.

go: finding module for package github.com/flc1125/go-twca/mid
go: downloading github.com/flc1125/go-twca v1.0.6
go: found github.com/flc1125/go-twca/mid in github.com/flc1125/go-twca v1.0.6

@flc1125
Copy link
Author

flc1125 commented Jun 3, 2024

I think it has resolved my issue. Thank you all very much for your assistance.

@ansaba @hyangah @suzmue @seankhliao @jba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Development

No branches or pull requests

7 participants