Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: revendor x/telemetry prior to go1.23.0 #67617

Open
findleyr opened this issue May 23, 2024 · 8 comments
Open

cmd/go: revendor x/telemetry prior to go1.23.0 #67617

findleyr opened this issue May 23, 2024 · 8 comments
Assignees
Milestone

Comments

@findleyr
Copy link
Contributor

This is a reminder issue to re-vendor x/telemetry with bug-fixes prior to go1.23rc1.

We are effectively treating x/telemetry as frozen for the moment, and want to make sure any bugfixes are included in the Go release.

@findleyr findleyr added this to the Go1.23 milestone May 23, 2024
@findleyr findleyr self-assigned this May 23, 2024
@dmitshur
Copy link
Contributor

Note that #36905 tracks re-vendoring all dependencies in the main Go repo, which will happen soon now that we're in the freeze. This issue can be kept open after that happens if there are more x/telemetry-specific changes to bring in afterwards.

@dmitshur
Copy link
Contributor

dmitshur commented Jun 4, 2024

FYI CL 589935 updated x/telemetry to v0.0.0-20240603224550-f2b69109f79b. Feel free to close this if that's enough for the needs of RC 1, or keep it open if you'd like to check in again, closer to RC 1 target date, in case more bug-fixes land in x/telemetry by then.

@findleyr
Copy link
Contributor Author

findleyr commented Jun 4, 2024

Thanks. I plan to revendor again on Friday, and close this issue at that time.

@findleyr
Copy link
Contributor Author

We still have a couple fixes pending, notably https://go.dev/cl/592017, which we want to land before revendoring.

@dr2chase
Copy link
Contributor

This is marked as a release blocker, is open, is not marked okay-after-RC1, and the scheduled cut for 1.23RC1 is roughly 24 hours from now. Where do we stand on this?

@findleyr
Copy link
Contributor Author

I think we're good now. It looks like Michael re-vendored in https://go.dev/cl/592255.

I'm going to move this to ok-after-rc1. I suspect we may have additional bug fixes after the RC.

@findleyr findleyr added the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Jun 17, 2024
@gopherbot gopherbot removed the okay-after-rc1 Used by release team to mark a release-blocker issue as okay to resolve either before or after rc1 label Jun 21, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/594021 mentions this issue: [release-branch.go1.23] cmd: vendor golang.org/x/telemetry@a740542

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/594019 mentions this issue: [release-branch.go1.23] cmd/vendor: pull in golang.org/x/telemetry@b4de734

@dmitshur dmitshur changed the title cmd/go: revendor x/telemetry prior to go1.23rc1 cmd/go: revendor x/telemetry prior to go1.23.0 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

5 participants
@dmitshur @dr2chase @gopherbot @findleyr and others