Skip to content

x/net/http2: TestServer_MaxQueuedControlFrames failures #67692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gopherbot opened this issue May 29, 2024 · 4 comments
Closed

x/net/http2: TestServer_MaxQueuedControlFrames failures #67692

gopherbot opened this issue May 29, 2024 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServer_MaxQueuedControlFrames"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestServer_MaxQueuedControlFrames
    server_test.go:1373: unexpected frame after exceeding maxQueuedControlFrames; want closed conn
        [FrameHeader PING flags=ACK len=8]
--- FAIL: TestServer_MaxQueuedControlFrames (0.22s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 29, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServer_MaxQueuedControlFrames"
2024-05-28 22:41 x_net-go1.21-linux-arm net@03c24c2d release-branch.go1.21@54c4745d x/net/http2.TestServer_MaxQueuedControlFrames (log)
=== RUN   TestServer_MaxQueuedControlFrames
    server_test.go:1373: unexpected frame after exceeding maxQueuedControlFrames; want closed conn
        [FrameHeader PING flags=ACK len=8]
--- FAIL: TestServer_MaxQueuedControlFrames (0.22s)

watchflakes

@neild
Copy link
Contributor

neild commented May 29, 2024

I believe this was already fixed by https://go.dev/cl/586249, which (among other things) changes TestServer_MaxQueuedControlFrames to check for a closed connection rather than a read error.

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServer_MaxQueuedControlFrames"
2024-05-28 22:41 x_net-go1.21-freebsd-riscv64 net@03c24c2d release-branch.go1.21@9488a444 x/net/http2.TestServer_MaxQueuedControlFrames (log)
=== RUN   TestServer_MaxQueuedControlFrames
    server_test.go:1373: unexpected frame after exceeding maxQueuedControlFrames; want closed conn
        [FrameHeader PING flags=ACK len=8]
--- FAIL: TestServer_MaxQueuedControlFrames (0.40s)
2024-05-28 22:41 x_net-go1.22-freebsd-riscv64 net@9f5b79b0 release-branch.go1.22@74565750 x/net/http2.TestServer_MaxQueuedControlFrames (log)
=== RUN   TestServer_MaxQueuedControlFrames
    server_test.go:1373: unexpected frame after exceeding maxQueuedControlFrames; want closed conn
        [FrameHeader PING flags=ACK len=8]
--- FAIL: TestServer_MaxQueuedControlFrames (0.54s)

watchflakes

@neild
Copy link
Contributor

neild commented May 30, 2024

net@03c24c2d
net@9f5b79b0

Both are before https://go.dev/cl/586249.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Archived in project
Development

No branches or pull requests

2 participants