Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/net/http2: TestServerWritesTrailers_WithoutFlush failures #67693

Open
gopherbot opened this issue May 29, 2024 · 4 comments
Open

x/net/http2: TestServerWritesTrailers_WithoutFlush failures #67693

gopherbot opened this issue May 29, 2024 · 4 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestServerWritesTrailers_WithoutFlush
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Range"
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Transfer-Encoding"
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Content-Length"
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Trailer"
    server_test.go:641: Error while expecting a HEADERS frame: i/o timeout
--- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 29, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-05-28 22:41 x_net-go1.22-js-wasm net@03c24c2d release-branch.go1.22@cb55d1a0 x/net/http2.TestServerWritesTrailers_WithoutFlush (log)
=== RUN   TestServerWritesTrailers_WithoutFlush
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Range"
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Transfer-Encoding"
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Content-Length"
    http2_test.go:66: 2024/05/28 22:42:13 ignoring invalid trailer "Trailer"
    server_test.go:641: Error while expecting a HEADERS frame: i/o timeout
--- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)
2024-05-28 22:41 x_net-gotip-js-wasm net@03c24c2d go@c26be72d x/net/http2.TestServerWritesTrailers_WithoutFlush (log)
=== RUN   TestServerWritesTrailers_WithoutFlush
    http2_test.go:66: 2024/05/28 22:42:24 ignoring invalid trailer "Range"
    http2_test.go:66: 2024/05/28 22:42:24 ignoring invalid trailer "Transfer-Encoding"
    http2_test.go:66: 2024/05/28 22:42:24 ignoring invalid trailer "Content-Length"
    http2_test.go:66: 2024/05/28 22:42:24 ignoring invalid trailer "Trailer"
    server_test.go:641: Error while expecting a HEADERS frame: i/o timeout
--- FAIL: TestServerWritesTrailers_WithoutFlush (0.01s)
2024-05-28 22:41 x_net-go1.22-js-wasm net@9f5b79b0 release-branch.go1.22@cb55d1a0 x/net/http2.TestServerWritesTrailers_WithoutFlush (log)
=== RUN   TestServerWritesTrailers_WithoutFlush
    http2_test.go:66: 2024/05/28 22:46:56 ignoring invalid trailer "Range"
    http2_test.go:66: 2024/05/28 22:46:56 ignoring invalid trailer "Transfer-Encoding"
    http2_test.go:66: 2024/05/28 22:46:56 ignoring invalid trailer "Content-Length"
    http2_test.go:66: 2024/05/28 22:46:56 ignoring invalid trailer "Trailer"
    server_test.go:641: Error while expecting a HEADERS frame: i/o timeout
--- FAIL: TestServerWritesTrailers_WithoutFlush (0.01s)
2024-05-28 22:41 x_net-gotip-js-wasm net@9f5b79b0 go@c26be72d x/net/http2.TestServerWritesTrailers_WithoutFlush (log)
=== RUN   TestServerWritesTrailers_WithoutFlush
    http2_test.go:66: 2024/05/28 22:42:28 ignoring invalid trailer "Range"
    http2_test.go:66: 2024/05/28 22:42:28 ignoring invalid trailer "Transfer-Encoding"
    server_test.go:641: Error while expecting a HEADERS frame: i/o timeout
    http2_test.go:66: 2024/05/28 22:42:28 ignoring invalid trailer "Content-Length"
    http2_test.go:66: 2024/05/28 22:42:28 ignoring invalid trailer "Trailer"
--- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

watchflakes

@neild
Copy link
Contributor

neild commented May 29, 2024

I can consistently reproduce this as c26be72, but not at HEAD, so I believe https://go.dev/cl/586249 already fixed this.

@neild neild closed this as completed May 29, 2024
@gopherbot gopherbot reopened this Jun 4, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-05-30 19:26 x_net-go1.22-js-wasm net@56082791 release-branch.go1.22@74565750 x/net/http2.TestServerWritesTrailers_WithoutFlush (log)
=== RUN   TestServerWritesTrailers_WithoutFlush
    http2_test.go:66: 2024/05/30 19:28:43 ignoring invalid trailer "Range"
    http2_test.go:66: 2024/05/30 19:28:43 ignoring invalid trailer "Transfer-Encoding"
    http2_test.go:66: 2024/05/30 19:28:43 ignoring invalid trailer "Content-Length"
    http2_test.go:66: 2024/05/30 19:28:43 ignoring invalid trailer "Trailer"
    server_test.go:2789: got no frame, want frame *http2.HeadersFrame
--- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/net/http2" && test == "TestServerWritesTrailers_WithoutFlush"
2024-06-03 16:01 x_net-gotip-js-wasm net@603e3e63 go@eaa7d9ff x/net/http2.TestServerWritesTrailers_WithoutFlush (log)
=== RUN   TestServerWritesTrailers_WithoutFlush
    http2_test.go:66: 2024/06/03 16:02:32 ignoring invalid trailer "Range"
    http2_test.go:66: 2024/06/03 16:02:32 ignoring invalid trailer "Transfer-Encoding"
    http2_test.go:66: 2024/06/03 16:02:32 ignoring invalid trailer "Content-Length"
    http2_test.go:66: 2024/06/03 16:02:32 ignoring invalid trailer "Trailer"
    server_test.go:2794: got no frame, want frame *http2.HeadersFrame
--- FAIL: TestServerWritesTrailers_WithoutFlush (0.02s)

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Status: Active
Development

No branches or pull requests

2 participants