Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/telemetry: merge sidecar.log and the uploader's debug log #67703

Open
hyangah opened this issue May 29, 2024 · 0 comments
Open

x/telemetry: merge sidecar.log and the uploader's debug log #67703

hyangah opened this issue May 29, 2024 · 0 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Milestone

Comments

@hyangah
Copy link
Contributor

hyangah commented May 29, 2024

Sidecar logging is done by the parent, while the uploader's logging is done by the upload process.
They also fight for the log prefix.
Sidecar process: https://github.com/golang/telemetry/blob/39ace7a40ae7adf90bd106518be3e8d9c21bc6ff/start.go#L230
Uploader: https://github.com/golang/telemetry/blob/39ace7a40ae7adf90bd106518be3e8d9c21bc6ff/internal/upload/run.go#L112

Since now we have only one way to trigger upload, let's keep only one way.

@gopherbot gopherbot added the telemetry x/telemetry issues label May 29, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 29, 2024
@mknyszek mknyszek added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. NeedsFix The path to resolution is known, but the work has not been done. labels Jun 3, 2024
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Projects
None yet
Development

No branches or pull requests

3 participants