Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/test/integration/codelens: TestUpgradeCodelens_Workspace failures #67727

Open
gopherbot opened this issue May 30, 2024 · 10 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestUpgradeCodelens_Workspace

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 30, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace"
2024-05-30 16:14 x_tools-gotip-windows-amd64-race tools@8d54ca12 go@e6504ce6 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace [ABORT] (log)
=== RUN   TestUpgradeCodelens_Workspace

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 30, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 30, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace"
2024-05-30 17:27 x_tools-gotip-windows-amd64-race tools@2e977ddd go@3f4be127 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace [ABORT] (log)
=== RUN   TestUpgradeCodelens_Workspace

watchflakes

@adonovan
Copy link
Member

Dup of #54461

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace"
2024-05-30 19:19 x_tools-go1.21-windows-amd64-race tools@6887e998 release-branch.go1.21@9488a444 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace [ABORT] (log)
=== RUN   TestUpgradeCodelens_Workspace

watchflakes

@gopherbot gopherbot reopened this May 31, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace"
2024-05-31 21:13 x_tools-gotip-windows-amd64-race tools@1e9d12dd go@9b43bfbc x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace [ABORT] (log)
=== RUN   TestUpgradeCodelens_Workspace

watchflakes

@findleyr
Copy link
Contributor

findleyr commented Jun 4, 2024

Still a dupe. Added more debug info in https://go.dev/cl/589956. (EDIT: fixed link).

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
@gopherbot gopherbot reopened this Jun 6, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace"
2024-06-06 18:30 x_tools-go1.21-windows-amd64-race tools@5e0f1d8d release-branch.go1.21@48103d97 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace [ABORT] (log)
=== RUN   TestUpgradeCodelens_Workspace

watchflakes

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.16.0 Jun 10, 2024
@findleyr
Copy link
Contributor

This may be worth understanding before gopls@v0.16.0. Added to the milestone, but I don't think this should block the prerelease.

@findleyr
Copy link
Contributor

Still not understood. The last failure has the new debugging output:

panic: detected hanging go command (golang/go#54461); waited 1m0.0112265s
	command:C:\b\s\w\ir\x\w\goroot\bin\go.exe list -m -e -json ...
	pid:2576

1m for go list -m seems like a deadlock or contention of some form. CC @matloob @samthanawalla for ideas.
Note that this test uses a file-based proxy.

@findleyr findleyr modified the milestones: gopls/v0.16.0, gopls/v0.17.0 Jun 18, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/codelens" && test == "TestUpgradeCodelens_Workspace"
2024-06-20 20:57 x_tools-go1.21-windows-amd64-race tools@dfdfa49f release-branch.go1.21@74ac37e9 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace [ABORT] (log)
=== RUN   TestUpgradeCodelens_Workspace

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Active
Development

No branches or pull requests

3 participants