Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: segfault obtaining buildID for go tool compile #67739

Closed
gopherbot opened this issue May 31, 2024 · 6 comments
Closed

cmd/go: segfault obtaining buildID for go tool compile #67739

gopherbot opened this issue May 31, 2024 · 6 comments
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

gopherbot commented May 31, 2024

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestChangeConfiguration/default
    configuration_test.go:46: waiting on:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing unknown file modification\" at least 1 time(s)" is met, must have:
        any diagnostics at the first position (5:4) matching `var (FooErr)` in "a/a.go"
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/05/30 17:49:39 Created View (#3)\n\tdirectory...
...
[Trace - 17:49:52.199 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2024/05/30 17:49:52 go/packages.Load #5\n\tview_id=\"4\"\n\tsnapshot=0\n\tdirectory=/home/swarming/.swarming/w/ir/x/t/gopls-test-2537235872/TestChangeConfiguration/default/work\n\tquery=[file=/home/swarming/.swarming/w/ir/x/t/gopls-test-2537235872/TestChangeConfiguration/default/work/a/a.go]\n\tpackages=1\n\tduration=3.175954631s\n"}


[Trace - 17:49:52.228 PM] Received notification '$/progress'.
Params: {"token":"8595116916885539764","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestChangeConfiguration/default"
--- FAIL: TestChangeConfiguration/default (13.76s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 31, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/misc" && test == "TestChangeConfiguration/default"
2024-05-30 17:27 x_tools-gotip-openbsd-ppc64 tools@2e977ddd go@e6504ce6 x/tools/gopls/internal/test/integration/misc.TestChangeConfiguration/default (log)
=== RUN   TestChangeConfiguration/default
    configuration_test.go:46: waiting on:
        Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)\ncompleted work \"diagnosing unknown file modification\" at least 1 time(s)" is met, must have:
        any diagnostics at the first position (5:4) matching `var (FooErr)` in "a/a.go"
        
        err:condition has final verdict Unmeetable
        
        state:
        #### log messages (see RPC logs for full text):
        	Info: "2024/05/30 17:49:39 Created View (#3)\n\tdirectory...
...
[Trace - 17:49:52.199 PM] Received notification 'window/logMessage'.
Params: {"type":3,"message":"2024/05/30 17:49:52 go/packages.Load #5\n\tview_id=\"4\"\n\tsnapshot=0\n\tdirectory=/home/swarming/.swarming/w/ir/x/t/gopls-test-2537235872/TestChangeConfiguration/default/work\n\tquery=[file=/home/swarming/.swarming/w/ir/x/t/gopls-test-2537235872/TestChangeConfiguration/default/work/a/a.go]\n\tpackages=1\n\tduration=3.175954631s\n"}


[Trace - 17:49:52.228 PM] Received notification '$/progress'.
Params: {"token":"8595116916885539764","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestChangeConfiguration/default"
--- FAIL: TestChangeConfiguration/default (13.76s)

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels May 31, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 31, 2024
@findleyr findleyr changed the title x/tools/gopls/internal/test/integration/misc: TestChangeConfiguration/default failures cmd/go: segfault obtaining buildID for go tool compile May 31, 2024
@findleyr
Copy link
Contributor

This is a Go command segfault, not a flake:

From the logs: "packages.Load error: err: exit status 1: stderr: go: error obtaining buildID for go tool compile: signal: segmentation fault (core dumped)"

CC @matloob @samthanawalla

@findleyr findleyr added GoCommand cmd/go and removed gopls Issues related to the Go language server, gopls. labels May 31, 2024
@gopherbot
Copy link
Contributor Author

Sorry, but I can't find a watchflakes script at the start of the issue description.
See https://go.dev/wiki/Watchflakes for details.

watchflakes

@matloob
Copy link
Contributor

matloob commented May 31, 2024

cc @golang/compiler

Assuming that the -toolexec flag isn't being passed in (and it doesn't look like it doing a quick glance at the test), it looks like the segfault is coming from the compiler. It's being invoked with the argument -V=full.

I tried running the test locally with tools and go at tip but couldn't reproduce. And it doesn't seem to be happening consistently on the builders.

@findleyr
Copy link
Contributor

Thanks @matloob.

Absent a reproducer, this seems unactionable. Should we close and see if it recurs?

@matloob
Copy link
Contributor

matloob commented May 31, 2024

Sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants