Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/types: make go/types more tolerant in case of 'import "C"' #6774

Open
griesemer opened this issue Nov 16, 2013 · 5 comments
Open

go/types: make go/types more tolerant in case of 'import "C"' #6774

griesemer opened this issue Nov 16, 2013 · 5 comments
Assignees
Milestone

Comments

@griesemer
Copy link
Contributor

@griesemer griesemer commented Nov 16, 2013

gotype $GOROOT/src/pkg/net

leads to several error messages due to unresolvable 'import "C"'.

go/types could be more tolerant with invalid operands and types to avoid follow-up
errors.

(For instance, conversions of the form T(x) could always succeed even if x is invalid.
Other operations should not report an error if an operand is already invalid.)
@minux
Copy link
Member

@minux minux commented Nov 16, 2013

Comment 1:

Issue #6775 has been merged into this issue.

@rsc
Copy link
Contributor

@rsc rsc commented Nov 27, 2013

Comment 2:

Labels changed: added go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 3:

Labels changed: added release-none, removed go1.3maybe.

@rsc
Copy link
Contributor

@rsc rsc commented Dec 4, 2013

Comment 4:

Labels changed: added repo-tools.

@griesemer griesemer self-assigned this Dec 4, 2013
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title go.tools/cmd/gotype: make gotype more tolerant in case of 'import "C"' x/tools/cmd/gotype: make gotype more tolerant in case of 'import "C"' Apr 14, 2015
@rsc rsc added this to the Unreleased milestone Apr 14, 2015
@rsc rsc removed this from the Unplanned milestone Apr 14, 2015
@rsc rsc removed the repo-tools label Apr 14, 2015
@griesemer griesemer changed the title x/tools/cmd/gotype: make gotype more tolerant in case of 'import "C"' go/types: make go/types more tolerant in case of 'import "C"' Jul 31, 2015
@griesemer griesemer added this to the Unplanned milestone Feb 25, 2017
@griesemer griesemer removed this from the Unreleased milestone Feb 25, 2017
@griesemer
Copy link
Contributor Author

@griesemer griesemer commented Jun 30, 2017

This probably requires the type-checker to be more tolerant when it encounters operands of unknown types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants