Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto/tls: darwin race builders failing on BenchmarkHandshakeServer/ECDHE-X25519-ECDSA-P256 #67748

Open
thanm opened this issue May 31, 2024 · 0 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@thanm
Copy link
Contributor

thanm commented May 31, 2024

The darwin race builder has been failing for some time with errors or this form:

=== RUN   BenchmarkHandshakeServer/ECDHE-P256-RSA
BenchmarkHandshakeServer/ECDHE-P256-RSA
    handshake_server_test.go:1346: #4: read tcp 127.0.0.1:62314->127.0.0.1:62310: use of closed network connection
        Read 0, wanted 51, got , wanted 140303000101160303002800000000000000005df832a2c7d4ac17570d9fc1962a774871f425eccda764cb20ea6acc31f0cb8b
    handshake_server_test.go:1349: #4: mismatch on read: got:000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000 want:140303000101160303002800000000000000005df832a2c7d4ac17570d9fc1962a774871f425eccda764cb20ea6acc31f0cb8b

Representative logs:

https://build.golang.org/log/a53a964e3bc25c4d3b3e4883e320e9f8b060f41b
https://ci.chromium.org/ui/p/golang/builders/ci/gotip-darwin-amd64-race/b8746453827322458849/overview

I can reproduce on a gomote, e.g.

$ export MOTE=thanm-gotip-darwin-amd64-race-0
$  gomote run $MOTE go/bin/go test -count=1 -bench=BenchmarkHandshakeServer crypto/tls

It looks as though this started at CL 586655 from inspecting the builder logs.

CC @FiloSottile @rolandshoemaker

@thanm thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label May 31, 2024
@thanm thanm added this to the Go1.23 milestone May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

1 participant