Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/perf/cmd/benchstat: wrong number of header columns in CSV output #67760

Open
ivanvc opened this issue May 31, 2024 · 1 comment
Open

x/perf/cmd/benchstat: wrong number of header columns in CSV output #67760

ivanvc opened this issue May 31, 2024 · 1 comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@ivanvc
Copy link

ivanvc commented May 31, 2024

Go version

go version go1.22.3 linux/amd64

Output of go env in your module/workspace:

GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/ivan/.cache/go-build'
GOENV='/home/ivan/.config/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/ivan/.local/share/asdf/installs/golang/1.22.2/packages/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/ivan/.local/share/asdf/installs/golang/1.22.2/packages'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/home/ivan/.local/share/asdf/installs/golang/1.22.3/go'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/home/ivan/.local/share/asdf/installs/golang/1.22.3/go/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.22.3'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='gcc'
CXX='g++'
CGO_ENABLED='1'
GOMOD='/home/ivan/Code/Personal/etcd/bbolt/go.mod'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build144319728=/tmp/go-build -gno-record-gcc-switches'

What did you do?

Running benchstat -output=csv returns an invalid CSV (according to RFC4180) because the header is missing columns.

I ran:

benchstat -confidence=0.75 -format=csv bm1.txt bm2.txt 2>/dev/null

Find attached both bm1.txt and bm2.txt.

What did you see happen?

The output is:

,bm1.txt,,bm2.txt
,sec/op,CI,sec/op,CI,vs base,P
_FreelistRelease10K-8,0.000298085,0%,0.000298883,0%,~,p=0.400 n=3
...

Notice that the header has 4 columns, while the table rows have 7.

What did you expect to see?

The headers in the CSV should have all of the columns, i.e.

,bm1.txt,,bm2.txt,,,
,sec/op,CI,sec/op,CI,vs base,P
_FreelistRelease10K-8,0.000298085,0%,0.000298883,0%,~,p=0.400 n=3
...
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label May 31, 2024
@gopherbot gopherbot added this to the Unreleased milestone May 31, 2024
@seankhliao seankhliao changed the title x/perf: wrong number of heade columns in CSV output x/perf/cmd/benchstat: wrong number of header columns in CSV output Jun 2, 2024
@mknyszek
Copy link
Contributor

mknyszek commented Jun 3, 2024

CC @aclements @dr2chase

@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 3, 2024
@archanaravindar archanaravindar added OS-NaCl GOOS=nacl, Native Client, removed in Go 1.14 and removed OS-NaCl GOOS=nacl, Native Client, removed in Go 1.14 labels Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Development

No branches or pull requests

4 participants