-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
os: follow-up pidfd fixes [freeze exception] #67826
Labels
Milestone
Comments
Yes, this is the one issue where I am aware of actual failures (some tests inside Google fail). The others are just problems I noticed when fixing the first. |
We reviewed this in a release meeting, and agreed to approve its "freeze exception" bit. Thanks for letting us know. |
https://go.dev/cl/588675 is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
This is a freeze exception request for feedback for https://go.dev/cl/588675. This CL is fixing #67634, #67640, and #67641, which are issues with the new pidfd support added in https://go.dev/cl/570036 and https://go.dev/cl/570681.
Since these are regressions, I don't think a freeze exception is strictly necessary, however the fix is a fairly invasive overhaul of the internals of os.Process, which I'd say has a medium risk of introducing new problems. The alternative to submitting this fix now would be to revert the pidfd changes and try again when the dev cycles opens again.
cc @golang/release @kolyshkin
The text was updated successfully, but these errors were encountered: