Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: delete command.Test #67920

Open
adonovan opened this issue Jun 10, 2024 · 3 comments
Open

x/tools/gopls: delete command.Test #67920

adonovan opened this issue Jun 10, 2024 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@adonovan
Copy link
Member

gopls has two commands (Test and RunTests) that are identical in behavior. Their only difference is the form of the parameters: three for Tests, versus a single struct of three fields for RunTest. Test is described as "legacy". We should delete it.

@adonovan adonovan added this to the gopls/v0.17.0 milestone Jun 10, 2024
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 10, 2024
@nikzayn
Copy link

nikzayn commented Jun 22, 2024

@adonovan can I take this issue up?

@adonovan
Copy link
Member Author

@adonovan can I take this issue up?

Thanks for offering. The code change should be trivial---just a deletion. But before we can do it we need to ascertain whether it is safe for existing clients. I know it is safe for Emacs+eglot, and I suspect it is safe for Vim+coc.nvim, which uses very little Go-specific client-side logic. That leaves primarily vscode-go; if @hyangah says it is safe, then let's remove it.

@nikzayn
Copy link

nikzayn commented Jun 22, 2024

/assign

I have raised the PR golang/tools#501. Yeah, sure we can wait for @hyangah to revert on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants