Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/test/integration/modfile: TestUnknownRevision/good/nested/default failures #67982

Closed
gopherbot opened this issue Jun 13, 2024 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/modfile" && test == "TestUnknownRevision/good/nested/default"

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestUnknownRevision/good/nested/default
goroutine profile: total 7
1 @ 0x434011 0x47309d 0x5ff551 0x5ff385 0x5fc3ab 0xe94210 0xe93e9a 0x547df4 0x47cfc1
#	0x5ff550	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x5ff384	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x5fc3aa	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe9420f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo3515914734/gopls/internal/test/integration/runner.go:198
#	0xe93e99	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo3515914734/gopls/internal/test/integration/runner.go:252
#	0x547df3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...

1 @ 0x4740ee 0x40b4dc 0x40b0b2 0x6ce507 0x47cfc1
#	0x6ce506	golang.org/x/tools/gopls/internal/protocol.LogEvent.func1.1+0x46	/home/swarming/.swarming/w/ir/x/w/targetrepo3515914734/gopls/internal/protocol/context.go:47

1 @ 0x4740ee 0x478725 0x84b4c5 0x47cfc1
#	0x478724	time.Sleep+0xe4						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/time.go:285
#	0x84b4c4	golang.org/x/tools/gopls/internal/filecache.gc+0x124	/home/swarming/.swarming/w/ir/x/w/targetrepo3515914734/gopls/internal/filecache/filecache.go:443

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-2732144922/TestUnknownRevision/good/nested/default: directory not empty
--- FAIL: TestUnknownRevision/good/nested/default (36.06s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 13, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/modfile" && test == "TestUnknownRevision/good/nested/default"
2024-06-13 17:34 x_tools-gotip-openbsd-amd64 tools@4419f4f3 go@956f8a67 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/good/nested/default (log)
=== RUN   TestUnknownRevision/good/nested/default
goroutine profile: total 7
1 @ 0x434011 0x47309d 0x5ff551 0x5ff385 0x5fc3ab 0xe94210 0xe93e9a 0x547df4 0x47cfc1
#	0x5ff550	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x5ff384	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x5fc3aa	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe9420f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo3515914734/gopls/internal/test/integration/runner.go:198
#	0xe93e99	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo3515914734/gopls/internal/test/integration/runner.go:252
#	0x547df3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...

1 @ 0x4740ee 0x40b4dc 0x40b0b2 0x6ce507 0x47cfc1
#	0x6ce506	golang.org/x/tools/gopls/internal/protocol.LogEvent.func1.1+0x46	/home/swarming/.swarming/w/ir/x/w/targetrepo3515914734/gopls/internal/protocol/context.go:47

1 @ 0x4740ee 0x478725 0x84b4c5 0x47cfc1
#	0x478724	time.Sleep+0xe4						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/time.go:285
#	0x84b4c4	golang.org/x/tools/gopls/internal/filecache.gc+0x124	/home/swarming/.swarming/w/ir/x/w/targetrepo3515914734/gopls/internal/filecache/filecache.go:443

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-2732144922/TestUnknownRevision/good/nested/default: directory not empty
--- FAIL: TestUnknownRevision/good/nested/default (36.06s)

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 13, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jun 13, 2024
@findleyr
Copy link
Contributor

Cleanup failure. We are probably leaking a go command, somehow.

@adonovan
Copy link
Member

Dup of #68087

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: Done
Development

No branches or pull requests

3 participants