Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/test/integration/misc: TestAssembly/default failing on secondary ports #68058

Closed
prattmic opened this issue Jun 18, 2024 · 1 comment
Closed

x/tools/gopls/internal/test/integration/misc: TestAssembly/default failing on secondary ports #68058

prattmic opened this issue Jun 18, 2024 · 1 comment
Assignees
@adonovan
Labels
gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@prattmic
Copy link
Member

Since the test was added in https://go.dev/cl/588395, TestAssembly/default has been failing continuously on several ports: linux-arm, linux-loong64, linux-ppc64*.

https://ci.chromium.org/p/golang/g/x-tools-gotip/console

e.g., https://ci.chromium.org/ui/p/golang/builders/ci/x_tools-gotip-linux-arm/b8745510430750955473/test-results?sortby=&groupby=

cc @adonovan
@prattmic prattmic added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 18, 2024
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jun 18, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jun 18, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/593416 mentions this issue: gopls/internal/test/integration/misc: skip asm test for 32-bit arm

@adonovan adonovan self-assigned this Jun 18, 2024
@adonovan adonovan changed the title x/tools: golang.org/x/tools/gopls/internal/test/integration/misc TestAssembly/default failing on secondary ports x/tools/gopls/internal/test/integration/misc: TestAssembly/default failing on secondary ports Jun 18, 2024
@gopherbot gopherbot added the gopls Issues related to the Go language server, gopls. label Jun 18, 2024
@dmitshur dmitshur added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 20, 2024
@findleyr findleyr mentioned this issue Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adonovan adonovan

Labels
gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@prattmic @dmitshur @adonovan @gopherbot