Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: test flakes cleaning module cache on openbsd: directory not empty #68087

Open
gopherbot opened this issue Jun 20, 2024 · 12 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Jun 20, 2024

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls/internal/test/.*` && goos == "openbsd" && `cleaning sandbox: cleaning modcache`

Issue created automatically to collect these failures.

Example (log):

=== RUN   TestUnknownRevision/bad/nested/default
goroutine profile: total 9
1 @ 0x434011 0x47309d 0x5ff551 0x5ff385 0x5fc3ab 0xe94cb0 0xe9493a 0x547df4 0x47cfc1
#	0x5ff550	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x5ff384	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x5fc3aa	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe94caf	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/gopls/internal/test/integration/runner.go:198
#	0xe94939	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/gopls/internal/test/integration/runner.go:252
#	0x547df3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...
#	0x4c8667	os.(*file).close+0x87							/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file_unix.go:333
#	0xc2968c	os.(*File).Close+0x2c							/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file_posix.go:23
#	0xc2932e	golang.org/x/tools/internal/gopathwalk.(*walker).walk+0x74e		/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:337
#	0xc28207	golang.org/x/tools/internal/gopathwalk.walkDir+0x347			/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:120
#	0xc3af25	golang.org/x/tools/internal/gopathwalk.WalkSkip+0x305			/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:77
#	0xc3ae12	golang.org/x/tools/internal/imports.(*ModuleResolver).scan.func4+0x1f2	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/imports/mod.go:643

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-3713062884/TestUnknownRevision/bad/nested/default/gopath/pkg/mod: directory not empty
        ): exit status 1; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-3713062884/TestUnknownRevision/bad/nested/default/gopath/pkg/mod/cache/download/example.com/@v: directory not empty
--- FAIL: TestUnknownRevision/bad/nested/default (34.95s)

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 20, 2024
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "golang.org/x/tools/gopls/internal/test/integration/modfile" && test == "TestUnknownRevision/bad/nested/default"
2024-06-20 14:20 x_tools-gotip-openbsd-amd64 tools@99779e9a go@4f77a835 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/nested/default (log)
=== RUN   TestUnknownRevision/bad/nested/default
goroutine profile: total 9
1 @ 0x434011 0x47309d 0x5ff551 0x5ff385 0x5fc3ab 0xe94cb0 0xe9493a 0x547df4 0x47cfc1
#	0x5ff550	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x5ff384	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x5fc3aa	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe94caf	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/gopls/internal/test/integration/runner.go:198
#	0xe94939	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/gopls/internal/test/integration/runner.go:252
#	0x547df3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...
#	0x4c8667	os.(*file).close+0x87							/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file_unix.go:333
#	0xc2968c	os.(*File).Close+0x2c							/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file_posix.go:23
#	0xc2932e	golang.org/x/tools/internal/gopathwalk.(*walker).walk+0x74e		/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:337
#	0xc28207	golang.org/x/tools/internal/gopathwalk.walkDir+0x347			/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:120
#	0xc3af25	golang.org/x/tools/internal/gopathwalk.WalkSkip+0x305			/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/gopathwalk/walk.go:77
#	0xc3ae12	golang.org/x/tools/internal/imports.(*ModuleResolver).scan.func4+0x1f2	/home/swarming/.swarming/w/ir/x/w/targetrepo2483330872/internal/imports/mod.go:643

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-3713062884/TestUnknownRevision/bad/nested/default/gopath/pkg/mod: directory not empty
        ): exit status 1; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-3713062884/TestUnknownRevision/bad/nested/default/gopath/pkg/mod/cache/download/example.com/@v: directory not empty
--- FAIL: TestUnknownRevision/bad/nested/default (34.95s)

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 20, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jun 20, 2024
@findleyr findleyr changed the title x/tools/gopls/internal/test/integration/modfile: TestUnknownRevision/bad/nested/default failures x/tools/gopls: test flakes cleaning module cache on openbsd: directory not empty Jun 25, 2024
@findleyr findleyr modified the milestones: Unreleased, gopls/v0.17.0 Jun 25, 2024
@gopherbot
Copy link
Contributor Author

Sorry, but there were parse errors in the watch flakes script.
The script I found was:

#!watchflakes
default <- pkg ~ "golang.org/x/tools/gopls/internal/test/.*" && goos == "openbsd" && `cleaning sandbox: cleaning modcache`

And the problems were:

script:2.18: ~ requires backquoted regexp

See https://go.dev/wiki/Watchflakes for details.

watchflakes

@findleyr
Copy link
Contributor

@matloob @samthanawalla @adonovan

Any particular reason why only on openbsd we'd be seeing these cleanup failures? Was there any recent change to the go command on openbsd? I don't think much has changed in gopls with respect to the integration test cleanup.

Not a super high priority, but curious.

@matloob
Copy link
Contributor

matloob commented Jun 26, 2024

I don't recall any changes specifically to openbsd

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls/internal/test/.*` && goos == "openbsd" && `cleaning sandbox: cleaning modcache`
2024-06-24 03:50 x_tools-go1.23-openbsd-amd64 tools@47bd819e release-branch.go1.23@7dff7439 x/tools/gopls/internal/test/integration/modfile.TestGovimModReadonly/default (log)
=== RUN   TestGovimModReadonly/default
goroutine profile: total 5
1 @ 0x434011 0x47309d 0x5ff551 0x5ff385 0x5fc3ab 0xe95870 0xe954fa 0x547df4 0x47cfc1
#	0x5ff550	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x5ff384	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x5fc3aa	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe9586f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo1504192603/gopls/internal/test/integration/runner.go:198
#	0xe954f9	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo1504192603/gopls/internal/test/integration/runner.go:252
#	0x547df3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...

1 @ 0x4740ee 0x40b4dc 0x40b0b2 0x6ce567 0x47cfc1
#	0x6ce566	golang.org/x/tools/gopls/internal/protocol.LogEvent.func1.1+0x46	/home/swarming/.swarming/w/ir/x/w/targetrepo1504192603/gopls/internal/protocol/context.go:47

1 @ 0x4740ee 0x478725 0x84b885 0x47cfc1
#	0x478724	time.Sleep+0xe4						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/time.go:285
#	0x84b884	golang.org/x/tools/gopls/internal/filecache.gc+0x124	/home/swarming/.swarming/w/ir/x/w/targetrepo1504192603/gopls/internal/filecache/filecache.go:443

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-2271365929/TestGovimModReadonly/default: directory not empty
--- FAIL: TestGovimModReadonly/default (33.84s)
2024-06-26 14:39 x_tools-go1.23-openbsd-amd64 tools@02912f74 release-branch.go1.23@7dff7439 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/nested/default (log)
=== RUN   TestUnknownRevision/bad/nested/default
goroutine profile: total 11
1 @ 0x434011 0x47309d 0x5ff551 0x5ff385 0x5fc3ab 0xe97b10 0xe9779a 0x547df4 0x47cfc1
#	0x5ff550	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x5ff384	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x5fc3aa	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe97b0f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo180469137/gopls/internal/test/integration/runner.go:198
#	0xe97799	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo180469137/gopls/internal/test/integration/runner.go:252
#	0x547df3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...
#	0x493e64	syscall.wait4+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/syscall/zsyscall_openbsd_amd64.go:43
#	0x4914e4	syscall.Wait4+0x24						/home/swarming/.swarming/w/ir/x/w/goroot/src/syscall/syscall_bsd.go:144
#	0x4c4185	os.(*Process).pidWait+0x85					/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec_unix.go:70
#	0x4c40ba	os.(*Process).wait+0x1a						/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec_unix.go:30
#	0x596da4	os.(*Process).Wait+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec.go:358
#	0x596d9c	os/exec.(*Cmd).Wait+0x3c					/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec/exec.go:901
#	0x72e464	golang.org/x/tools/internal/gocommand.runCmdContext.func4+0x24	/home/swarming/.swarming/w/ir/x/w/targetrepo180469137/internal/gocommand/invoke.go:382

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-2935470729/TestUnknownRevision/bad/nested/default: directory not empty
--- FAIL: TestUnknownRevision/bad/nested/default (37.60s)
2024-06-26 17:06 x_tools-go1.22-openbsd-amd64 tools@b297f5a4 release-branch.go1.22@ceaf26ec x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/nested/default (log)
=== RUN   TestUnknownRevision/bad/nested/default
goroutine profile: total 7
1 @ 0x4371f1 0x472a3d 0x5e7e11 0x5e7c45 0x5e4a6b 0xe693f0 0xe69062 0x53d35b 0x479341
#	0x472a3c	runtime/pprof.runtime_goroutineProfileWithLabels+0x1c				/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mprof.go:1079
#	0x5e7e10	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:774
#	0x5e7c44	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:734
#	0x5e4a6a	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:369
#	0xe693ef	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo1810633247/gopls/internal/test/integration/runner.go:198
#	0xe69061	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xf01	/home/swarming/.swarming/w/ir/x/w/targetrepo1810633247/gopls/internal/test/integration/runner.go:252
#	0x53d35a	testing.tRunner+0xfa								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689
...
1 @ 0x4410ce 0x40c07f 0x40bcb2 0x6a82e7 0x479341
#	0x6a82e6	golang.org/x/tools/gopls/internal/protocol.LogEvent.func1.1+0x46	/home/swarming/.swarming/w/ir/x/w/targetrepo1810633247/gopls/internal/protocol/context.go:47

1 @ 0x4410ce 0x475b45 0x82a3a5 0x479341
#	0x475b44	time.Sleep+0x104					/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/time.go:195
#	0x82a3a4	golang.org/x/tools/gopls/internal/filecache.gc+0x124	/home/swarming/.swarming/w/ir/x/w/targetrepo1810633247/gopls/internal/filecache/filecache.go:443

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-276728773/TestUnknownRevision/bad/nested/default/gopath/pkg/mod: directory not empty
        ): exit status 1; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-276728773/TestUnknownRevision/bad/nested/default: directory not empty
--- FAIL: TestUnknownRevision/bad/nested/default (35.54s)

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls/internal/test/.*` && goos == "openbsd" && `cleaning sandbox: cleaning modcache`
2024-06-27 17:53 x_tools-gotip-openbsd-amd64 tools@5cc2d0b1 go@ea537cca x/tools/gopls/internal/test/integration/modfile.TestBadlyVersionedModule/default/default (log)
=== RUN   TestBadlyVersionedModule/default/default
goroutine profile: total 6
1 @ 0x434011 0x47309d 0x5ff571 0x5ff3a5 0x5fc3cb 0xe98370 0xe97ffa 0x547e14 0x47cfc1
#	0x5ff570	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x5ff3a4	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x5fc3ca	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe9836f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo2204670350/gopls/internal/test/integration/runner.go:198
#	0xe97ff9	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo2204670350/gopls/internal/test/integration/runner.go:252
#	0x547e13	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...
1 @ 0x4740ee 0x40b4dc 0x40b0b2 0x6ce587 0x47cfc1
#	0x6ce586	golang.org/x/tools/gopls/internal/protocol.LogEvent.func1.1+0x46	/home/swarming/.swarming/w/ir/x/w/targetrepo2204670350/gopls/internal/protocol/context.go:47

1 @ 0x4740ee 0x478725 0x84bc25 0x47cfc1
#	0x478724	time.Sleep+0xe4						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/time.go:285
#	0x84bc24	golang.org/x/tools/gopls/internal/filecache.gc+0x124	/home/swarming/.swarming/w/ir/x/w/targetrepo2204670350/gopls/internal/filecache/filecache.go:443

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-2886103921/TestBadlyVersionedModule/default/default/gopath/pkg/mod/cache/download/example.com/blah: directory not empty
        ): exit status 1; removing files: <nil>
--- FAIL: TestBadlyVersionedModule/default/default (37.62s)

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls/internal/test/.*` && goos == "openbsd" && `cleaning sandbox: cleaning modcache`
2024-06-27 17:53 x_tools-go1.23-openbsd-ppc64 tools@5cc2d0b1 release-branch.go1.23@7dff7439 x/tools/gopls/internal/test/integration/modfile.TestUnknownRevision/bad/default/default (log)
=== RUN   TestUnknownRevision/bad/default/default
goroutine profile: total 11
1 @ 0x2b3a0 0x84fec 0x8da24 0x1487b0 0x148188 0x1485b4 0xcb294 0xe0958 0xe0919 0xe088c 0xcb1cc 0x34a878 0x34a855 0x93c24
#	0x1487af	bytes.growSlice+0xaf						/home/swarming/.swarming/w/ir/x/w/goroot/src/bytes/buffer.go:249
#	0x148187	bytes.(*Buffer).grow+0x157					/home/swarming/.swarming/w/ir/x/w/goroot/src/bytes/buffer.go:151
#	0x1485b3	bytes.(*Buffer).ReadFrom+0x63					/home/swarming/.swarming/w/ir/x/w/goroot/src/bytes/buffer.go:209
#	0xcb293		io.copyBuffer+0x1d3						/home/swarming/.swarming/w/ir/x/w/goroot/src/io/io.go:415
#	0xe0957		io.Copy+0x77							/home/swarming/.swarming/w/ir/x/w/goroot/src/io/io.go:388
#	0xe0918		os.genericWriteTo+0x38						/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file.go:275
#	0xe088b		os.(*File).WriteTo+0x8b						/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file.go:253
...
#	0xac323		syscall.wait4+0x73						/home/swarming/.swarming/w/ir/x/w/goroot/src/syscall/zsyscall_openbsd_ppc64.go:43
#	0xa96af		syscall.Wait4+0x4f						/home/swarming/.swarming/w/ir/x/w/goroot/src/syscall/syscall_bsd.go:144
#	0xdf0a7		os.(*Process).pidWait+0xc7					/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec_unix.go:70
#	0xdef97		os.(*Process).wait+0x37						/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec_unix.go:30
#	0x1b4003	os.(*Process).Wait+0x53						/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec.go:358
#	0x1b3ff8	os/exec.(*Cmd).Wait+0x48					/home/swarming/.swarming/w/ir/x/w/goroot/src/os/exec/exec.go:901
#	0x34a59f	golang.org/x/tools/internal/gocommand.runCmdContext.func4+0x2f	/home/swarming/.swarming/w/ir/x/w/targetrepo3113893529/internal/gocommand/invoke.go:382

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-1575803608/TestUnknownRevision/bad/default/default: directory not empty
--- FAIL: TestUnknownRevision/bad/default/default (33.27s)

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls/internal/test/.*` && goos == "openbsd" && `cleaning sandbox: cleaning modcache`
2024-06-28 20:28 x_tools-go1.23-openbsd-amd64 tools@fcf54632 release-branch.go1.23@7dff7439 x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (log)
=== RUN   TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default
goroutine profile: total 8
1 @ 0x434011 0x47309d 0x5ff551 0x5ff385 0x5fc3ab 0xe97e50 0xe97ada 0x547df4 0x47cfc1
#	0x5ff550	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:773
#	0x5ff384	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:732
#	0x5fc3aa	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe97e4f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo3428335984/gopls/internal/test/integration/runner.go:198
#	0xe97ad9	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo3428335984/gopls/internal/test/integration/runner.go:252
#	0x547df3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...
#	0x4c8667	os.(*file).close+0x87							/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file_unix.go:333
#	0xbebcac	os.(*File).Close+0x2c							/home/swarming/.swarming/w/ir/x/w/goroot/src/os/file_posix.go:23
#	0xbeb94e	golang.org/x/tools/internal/gopathwalk.(*walker).walk+0x74e		/home/swarming/.swarming/w/ir/x/w/targetrepo3428335984/internal/gopathwalk/walk.go:337
#	0xbea827	golang.org/x/tools/internal/gopathwalk.walkDir+0x347			/home/swarming/.swarming/w/ir/x/w/targetrepo3428335984/internal/gopathwalk/walk.go:120
#	0xbfd545	golang.org/x/tools/internal/gopathwalk.WalkSkip+0x305			/home/swarming/.swarming/w/ir/x/w/targetrepo3428335984/internal/gopathwalk/walk.go:77
#	0xbfd432	golang.org/x/tools/internal/imports.(*ModuleResolver).scan.func4+0x1f2	/home/swarming/.swarming/w/ir/x/w/targetrepo3428335984/internal/imports/mod.go:643

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-3325540296/TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default/gopath/pkg/mod: directory not empty
        ): exit status 1; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-3325540296/TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default: directory not empty
--- FAIL: TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (33.09s)

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls/internal/test/.*` && goos == "openbsd" && `cleaning sandbox: cleaning modcache`
2024-07-07 19:31 x_tools-gotip-openbsd-amd64 tools@33be3ef8 go@6d89b38e x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (log)
=== RUN   TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default
goroutine profile: total 6
1 @ 0x434011 0x47317d 0x5ff6d1 0x5ff505 0x5fc52b 0xe985b0 0xe9823a 0x547ef4 0x47d0a1
#	0x5ff6d0	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:774
#	0x5ff504	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:733
#	0x5fc52a	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe985af	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo510357261/gopls/internal/test/integration/runner.go:198
#	0xe98239	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo510357261/gopls/internal/test/integration/runner.go:252
#	0x547ef3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...
1 @ 0x4741ce 0x40b4dc 0x40b0b2 0x6ce547 0x47d0a1
#	0x6ce546	golang.org/x/tools/gopls/internal/protocol.LogEvent.func1.1+0x46	/home/swarming/.swarming/w/ir/x/w/targetrepo510357261/gopls/internal/protocol/context.go:47

1 @ 0x4741ce 0x478805 0x7f62e5 0x47d0a1
#	0x478804	time.Sleep+0xe4						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/time.go:285
#	0x7f62e4	golang.org/x/tools/gopls/internal/filecache.gc+0x124	/home/swarming/.swarming/w/ir/x/w/targetrepo510357261/gopls/internal/filecache/filecache.go:443

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-2742982158/TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default/gopath/pkg/mod: directory not empty
        ): exit status 1; removing files: <nil>
--- FAIL: TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (32.97s)

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls/internal/test/.*` && goos == "openbsd" && `cleaning sandbox: cleaning modcache`
2024-07-16 16:13 x_tools-go1.22-openbsd-amd64 tools@25ed04f2 release-branch.go1.22@9e148a41 x/tools/gopls/internal/test/integration/modfile.TestGovimModReadonly/default (log)
=== RUN   TestGovimModReadonly/default
goroutine profile: total 5
1 @ 0x4371f1 0x472a3d 0x5e7eb1 0x5e7ce5 0x5e4b0b 0xe6abb0 0xe6a822 0x53d35b 0x479341
#	0x472a3c	runtime/pprof.runtime_goroutineProfileWithLabels+0x1c				/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/mprof.go:1079
#	0x5e7eb0	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:774
#	0x5e7ce4	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:734
#	0x5e4b0a	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:369
#	0xe6abaf	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo2880009116/gopls/internal/test/integration/runner.go:198
#	0xe6a821	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xf01	/home/swarming/.swarming/w/ir/x/w/targetrepo2880009116/gopls/internal/test/integration/runner.go:252
#	0x53d35a	testing.tRunner+0xfa								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1689
...

1 @ 0x4410ce 0x40c07f 0x40bcb2 0x6a3e07 0x479341
#	0x6a3e06	golang.org/x/tools/gopls/internal/protocol.LogEvent.func1.1+0x46	/home/swarming/.swarming/w/ir/x/w/targetrepo2880009116/gopls/internal/protocol/context.go:47

1 @ 0x4410ce 0x475b45 0x82a965 0x479341
#	0x475b44	time.Sleep+0x104					/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/time.go:195
#	0x82a964	golang.org/x/tools/gopls/internal/filecache.gc+0x124	/home/swarming/.swarming/w/ir/x/w/targetrepo2880009116/gopls/internal/filecache/filecache.go:443

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: <nil>; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-2617873409/TestGovimModReadonly/default/gopath/pkg/mod/cache/download/example.com/@v: directory not empty
--- FAIL: TestGovimModReadonly/default (34.28s)

watchflakes

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg ~ `golang.org/x/tools/gopls/internal/test/.*` && goos == "openbsd" && `cleaning sandbox: cleaning modcache`
2024-07-19 17:32 x_tools-gotip-openbsd-amd64 tools@2fb3ebe9 go@f0de94ff x/tools/gopls/internal/test/integration/codelens.TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (log)
=== RUN   TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default
goroutine profile: total 8
1 @ 0x434511 0x47367d 0x5ffdb1 0x5ffbe5 0x5fca0b 0xe99530 0xe991ba 0x5483d4 0x47d521
#	0x5ffdb0	runtime/pprof.writeRuntimeProfile+0xb0						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:793
#	0x5ffbe4	runtime/pprof.writeGoroutine+0x44						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:752
#	0x5fca0a	runtime/pprof.(*Profile).WriteTo+0x14a						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/pprof/pprof.go:374
#	0xe9952f	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1.1+0x6f	/home/swarming/.swarming/w/ir/x/w/targetrepo698928008/gopls/internal/test/integration/runner.go:198
#	0xe991b9	golang.org/x/tools/gopls/internal/test/integration.(*Runner).Run.func1+0xeb9	/home/swarming/.swarming/w/ir/x/w/targetrepo698928008/gopls/internal/test/integration/runner.go:252
#	0x5483d3	testing.tRunner+0xf3								/home/swarming/.swarming/w/ir/x/w/goroot/src/testing/testing.go:1690

...
#	0xcc4684	golang.org/x/tools/gopls/internal/cache.(*importsState).refreshProcessEnv+0x1a4	/home/swarming/.swarming/w/ir/x/w/targetrepo698928008/gopls/internal/cache/imports.go:245
#	0xcc36e1	golang.org/x/tools/gopls/internal/cache.(*refreshTimer).schedule.func1+0xc1	/home/swarming/.swarming/w/ir/x/w/targetrepo698928008/gopls/internal/cache/imports.go:73

1 @ 0x4746ce 0x478d05 0x7f3765 0x47d521
#	0x478d04	time.Sleep+0xe4						/home/swarming/.swarming/w/ir/x/w/goroot/src/runtime/time.go:285
#	0x7f3764	golang.org/x/tools/gopls/internal/filecache.gc+0x124	/home/swarming/.swarming/w/ir/x/w/targetrepo698928008/gopls/internal/filecache/filecache.go:443

    runner.go:199: closing the sandbox: error(s) cleaning sandbox: cleaning modcache: go command failed (stdout: ) (stderr: go: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-186031656/TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default/gopath/pkg/mod: directory not empty
        ): exit status 1; removing files: unlinkat /home/swarming/.swarming/w/ir/x/t/gopls-test-186031656/TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default: directory not empty
--- FAIL: TestUpgradeCodelens_Workspace/Upgrade_individual_dependency_vendoring=true/default (32.81s)

watchflakes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Status: No status
Development

No branches or pull requests

4 participants