Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: links in summaries have opacity zero #68132

favonia opened this issue Jun 23, 2024 · 5 comments

x/pkgsite: links in summaries have opacity zero #68132

favonia opened this issue Jun 23, 2024 · 5 comments


Copy link

favonia commented Jun 23, 2024

What is the URL of the page with the issue?

What is your user agent?

Mozilla/5.0 (X11; Linux x86_64; rv:127.0) Gecko/20100101 Firefox/127.0



What did you do?

Navigate down to the section.

What did you see happen?

Links in <summary> are not visible (opacity: 0 in terms of CSS).

What did you expect to see?

Links should be visible even within <summary>.

@gopherbot gopherbot added this to the Unreleased milestone Jun 23, 2024
Copy link

Bug aside, I would not recommend, in general, putting clickable things in clickable things as it causes accessibility issues. I would recommend removing the links from the summary button, even if this gets fixed.

Copy link
Contributor Author

favonia commented Jun 23, 2024

@jimmyfrasche You are right. Working on it.

mpldr added a commit to mpldr-pulls/pkgsite that referenced this issue Jun 25, 2024
Currently, links in Readmes are invisible when in the header of
a details element. A similar rule exists for the paragraph symbol, but
is overwritten by the following block.

Remove instructions that make links in summary invisible and remove
inactive rule for h2 elements.

Fixes golang/go#68132
Copy link

Change mentions this issue: static/frontend: always show links in readme files

Copy link

ansaba commented Jun 26, 2024

cc: @jba

Copy link

findleyr commented Jul 8, 2024

Did some digging:

The opacity:0 was added in, presumably to make the anchor links hidden.
I do not now why the summary selector was included in that change.

Then the opacity:0 style for anchor links was rendered obsolete by

So the fix LGTM.

@findleyr findleyr modified the milestones: Unreleased, pkgsite/backlog Jul 8, 2024
@findleyr findleyr self-assigned this Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

No branches or pull requests

5 participants