-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: list with -export and -covermode=atomic fails to build [1.22 backport] #68222
Labels
Milestone
Comments
gopherbot
added
CherryPickCandidate
Used during the release process for point releases
GoCommand
cmd/go
labels
Jun 27, 2024
Change https://go.dev/cl/595496 mentions this issue: |
Change https://go.dev/cl/595495 mentions this issue: |
matloob
added
CherryPickApproved
Used during the release process for point releases
and removed
CherryPickCandidate
Used during the release process for point releases
labels
Jun 27, 2024
gopherbot
pushed a commit
that referenced
this issue
Jul 10, 2024
…ons for 'go list -cover' When -covermode is set to atomic, instrumented packages need to import sync/atomic. If this is not already imported by a package being instrumented, the build needs to ensure that sync/atomic is compiled whenever 'go list' is run in a way that triggers package builds. The build config was already being made to ensure the import, but only after the action graph had been created, so there was no guarantee that sync/atomic would be built when needed. For #65264. For #68212 Fixes #68222 Change-Id: Ib3f1e102ce2ef554ea08330d9db69a8c98790ac5 Reviewed-on: https://go-review.googlesource.com/c/go/+/560236 Run-TryBot: Bryan Mills <bcmills@google.com> Auto-Submit: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Reviewed-by: Michael Matloob <matloob@golang.org> (cherry picked from commit ac08c05) Reviewed-on: https://go-review.googlesource.com/c/go/+/595496 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Than McIntosh <thanm@google.com>
Closed by merging 49906f9 to release-branch.go1.22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@matloob requested issue #65264 to be considered for backport to the next 1.22 minor release.
The text was updated successfully, but these errors were encountered: